On Thu, Mar 21, 2013 at 04:13:35PM +, Christian Weisgerber wrote:
Lawrence Teo l...@openbsd.org wrote:
The checksum flags listed in the mbuf(9) man page do not match the ones
in mbuf.h. In addition, the m_pkthdr.csum variable name should be
m_pkthdr.csum_flags.
The following diff fixes both issues.
OK?
Okay, but while you're there, could you remove the /IPv4 from the
M_{TCP,UDP}_CSUM_IN_* descriptions? We also use this for TCP or
UDP over IPv6, e.g. on newer bge(4) chips.
I'm not sure there's a point in documenting the M_ICMP_CSUM_* flags.
They aren't actually implemented in the stack, few chipsets support
them, and I doubt there would be much benefit.
Thank you for your feedback. I have revised the diff to remove /IPv4
from the relevant descriptions, and it no longer includes the
M_ICMP_CSUM_* flags that I added earlier.
OK?
Index: mbuf.9
===
RCS file: /cvs/src/share/man/man9/mbuf.9,v
retrieving revision 1.59
diff -u -p -r1.59 mbuf.9
--- mbuf.9 3 Jan 2013 07:53:22 - 1.59
+++ mbuf.9 22 Mar 2013 01:37:06 -
@@ -302,28 +302,28 @@ buffer holding the data (size MHLEN).
.El
.Pp
The
-.Fa m_pkthdr.csum
+.Fa m_pkthdr.csum_flags
variable can take the following values:
.Pp
.Bl -tag -compact -offset indent -width XX
.It Dv M_IPV4_CSUM_OUT
IPv4 checksum needed.
-.It Dv M_TCPV4_CSUM_OUT
+.It Dv M_TCP_CSUM_OUT
TCP checksum needed.
-.It Dv M_UDPV4_CSUM_OUT
+.It Dv M_UDP_CSUM_OUT
UDP checksum needed.
.It Dv M_IPV4_CSUM_IN_OK
IPv4 checksum verified.
.It Dv M_IPV4_CSUM_IN_BAD
IPv4 checksum bad.
.It Dv M_TCP_CSUM_IN_OK
-TCP/IPv4 checksum verified.
+TCP checksum verified.
.It Dv M_TCP_CSUM_IN_BAD
-TCP/IPv4 checksum bad.
+TCP checksum bad.
.It Dv M_UDP_CSUM_IN_OK
-UDP/IPv4 checksum verified.
+UDP checksum verified.
.It Dv M_UDP_CSUM_IN_BAD
-UDP/IPv4 checksum bad.
+UDP checksum bad.
.El
.Pp
When only M_EXT flag is set, an external storage buffer is being used to
