Re: mbuf leak ip_insertoptions

2021-02-22 Thread Vitaliy Makkoveev
ok mvs@ > On 22 Feb 2021, at 18:51, Alexander Bluhm wrote: > > Hi, > > ip_insertoptions() may prepend a mbuf. In this case "goto bad" has > to free the new chain. Currently we leak the new mbuf in front of > the old chain. NetBSD has fixed this bug here: > > > r

Re: mbuf leak ip_insertoptions

2021-02-22 Thread Klemens Nanni
On Mon, Feb 22, 2021 at 04:51:09PM +0100, Alexander Bluhm wrote: > Free m instead of m0 in the bad case. This allows to simplify a > bunch of goto done. OK kn

mbuf leak ip_insertoptions

2021-02-22 Thread Alexander Bluhm
Hi, ip_insertoptions() may prepend a mbuf. In this case "goto bad" has to free the new chain. Currently we leak the new mbuf in front of the old chain. NetBSD has fixed this bug here: revision 1.33 date: 1996-10-11 18:19:08 +; author: is; state: Exp; lines: