Re: memory leaks in bwfm

2018-09-18 Thread Patrick Wildt
The code hands off the reponsibility of ctl and ctl->buf to bs_txctl which will free both buffers if there is an error enqueueing the command. Only if bs_txctl succeeds in enqueueing and there is a response timeout we can free it. Thus, not ok. If this pattern is not understandable then we can

Re: memory leaks in bwfm

2018-09-18 Thread Claudio Jeker
On Tue, Sep 18, 2018 at 03:52:45PM +1000, Jonathan Gray wrote: > Index: bwfm.c > === > RCS file: /cvs/src/sys/dev/ic/bwfm.c,v > retrieving revision 1.54 > diff -u -p -r1.54 bwfm.c > --- bwfm.c25 Jul 2018 20:37:11 - 1.54 >

memory leaks in bwfm

2018-09-17 Thread Jonathan Gray
Index: bwfm.c === RCS file: /cvs/src/sys/dev/ic/bwfm.c,v retrieving revision 1.54 diff -u -p -r1.54 bwfm.c --- bwfm.c 25 Jul 2018 20:37:11 - 1.54 +++ bwfm.c 18 Sep 2018 05:21:30 - @@ -1297,6 +1297,7 @@