Re: mvpcie(4): fix panic if "reset-gpios" is not available

2022-02-14 Thread Theo Buehler
On Mon, Feb 14, 2022 at 12:00:24PM +1100, Jonathan Gray wrote: > On Sun, Feb 13, 2022 at 03:17:27PM +0100, Theo Buehler wrote: > > On Sun, Feb 13, 2022 at 02:30:21PM +0100, Tobias Heider wrote: > > > OF_getproplen() will return -1 if "reset-gpios" is not found which > > > currently causes a panic:

Re: mvpcie(4): fix panic if "reset-gpios" is not available

2022-02-14 Thread Tobias Heider
On Mon, Feb 14, 2022 at 12:00:24PM +1100, Jonathan Gray wrote: > On Sun, Feb 13, 2022 at 03:17:27PM +0100, Theo Buehler wrote: > > On Sun, Feb 13, 2022 at 02:30:21PM +0100, Tobias Heider wrote: > > > OF_getproplen() will return -1 if "reset-gpios" is not found which > > > currently causes a panic:

Re: mvpcie(4): fix panic if "reset-gpios" is not available

2022-02-13 Thread Jonathan Gray
On Sun, Feb 13, 2022 at 03:17:27PM +0100, Theo Buehler wrote: > On Sun, Feb 13, 2022 at 02:30:21PM +0100, Tobias Heider wrote: > > OF_getproplen() will return -1 if "reset-gpios" is not found which > > currently causes a panic: > > > > panic: malloc: allocation too large, type = 2, size = 42949672

Re: mvpcie(4): fix panic if "reset-gpios" is not available

2022-02-13 Thread Mark Kettenis
> Date: Mon, 14 Feb 2022 01:41:45 +1100 > From: Jonathan Gray > > On Mon, Feb 14, 2022 at 01:31:57AM +1100, Jonathan Gray wrote: > > On Sun, Feb 13, 2022 at 03:17:27PM +0100, Theo Buehler wrote: > > > On Sun, Feb 13, 2022 at 02:30:21PM +0100, Tobias Heider wrote: > > > > OF_getproplen() will retu

Re: mvpcie(4): fix panic if "reset-gpios" is not available

2022-02-13 Thread Mark Kettenis
> Date: Mon, 14 Feb 2022 01:31:57 +1100 > From: Jonathan Gray > > On Sun, Feb 13, 2022 at 03:17:27PM +0100, Theo Buehler wrote: > > On Sun, Feb 13, 2022 at 02:30:21PM +0100, Tobias Heider wrote: > > > OF_getproplen() will return -1 if "reset-gpios" is not found which > > > currently causes a pani

Re: mvpcie(4): fix panic if "reset-gpios" is not available

2022-02-13 Thread Jonathan Gray
On Mon, Feb 14, 2022 at 01:31:57AM +1100, Jonathan Gray wrote: > On Sun, Feb 13, 2022 at 03:17:27PM +0100, Theo Buehler wrote: > > On Sun, Feb 13, 2022 at 02:30:21PM +0100, Tobias Heider wrote: > > > OF_getproplen() will return -1 if "reset-gpios" is not found which > > > currently causes a panic:

Re: mvpcie(4): fix panic if "reset-gpios" is not available

2022-02-13 Thread Mark Kettenis
> Date: Sun, 13 Feb 2022 14:30:21 +0100 > From: Tobias Heider > > OF_getproplen() will return -1 if "reset-gpios" is not found which > currently causes a panic: > > panic: malloc: allocation too large, type = 2, size = 4294967295 > > Below is a fix. > > ok? ok kettenis@ > Index: mvpcie.c > =

Re: mvpcie(4): fix panic if "reset-gpios" is not available

2022-02-13 Thread Jonathan Gray
On Sun, Feb 13, 2022 at 03:17:27PM +0100, Theo Buehler wrote: > On Sun, Feb 13, 2022 at 02:30:21PM +0100, Tobias Heider wrote: > > OF_getproplen() will return -1 if "reset-gpios" is not found which > > currently causes a panic: > > > > panic: malloc: allocation too large, type = 2, size = 42949672

Re: mvpcie(4): fix panic if "reset-gpios" is not available

2022-02-13 Thread Theo Buehler
On Sun, Feb 13, 2022 at 02:30:21PM +0100, Tobias Heider wrote: > OF_getproplen() will return -1 if "reset-gpios" is not found which > currently causes a panic: > > panic: malloc: allocation too large, type = 2, size = 4294967295 > > Below is a fix. There are more of these: dev/ofw/ofw_regulator

Re: mvpcie(4): fix panic if "reset-gpios" is not available

2022-02-13 Thread Patrick Wildt
Am Sun, Feb 13, 2022 at 01:39:22PM + schrieb Klemens Nanni: > On Sun, Feb 13, 2022 at 02:30:21PM +0100, Tobias Heider wrote: > > OF_getproplen() will return -1 if "reset-gpios" is not found which > > currently causes a panic: > > > > panic: malloc: allocation too large, type = 2, size = 429496

Re: mvpcie(4): fix panic if "reset-gpios" is not available

2022-02-13 Thread Klemens Nanni
On Sun, Feb 13, 2022 at 02:30:21PM +0100, Tobias Heider wrote: > OF_getproplen() will return -1 if "reset-gpios" is not found which > currently causes a panic: > > panic: malloc: allocation too large, type = 2, size = 4294967295 > > Below is a fix. > > ok? OK kn > > Index: mvpcie.c > =

mvpcie(4): fix panic if "reset-gpios" is not available

2022-02-13 Thread Tobias Heider
OF_getproplen() will return -1 if "reset-gpios" is not found which currently causes a panic: panic: malloc: allocation too large, type = 2, size = 4294967295 Below is a fix. ok? Index: mvpcie.c === RCS file: /mount/openbsd/cvs/src/