Re: netstart(8): remove sed

2022-11-23 Thread Klemens Nanni
On Wed, Nov 23, 2022 at 08:55:56AM -0700, Theo de Raadt wrote: > > It mounts /usr before running /etc/netstart. > > yes that is a fairly recent change. So no problem with sed/awk in netstart and thus no need for ksh bits? Sounds good.

Re: netstart(8): remove sed

2022-11-23 Thread Theo de Raadt
Klemens Nanni wrote: > 449 mount -s /var >/dev/null 2>&1 # cannot be on NFS > 450 mount -s /var/log >/dev/null 2>&1 # cannot be on NFS > 451 mount -s /usr >/dev/null 2>&1 # if NFS, fstab must use IP > address > 452 > 453 start_daemon slaacd dhcpleased

Re: netstart(8): remove sed

2022-11-23 Thread Klemens Nanni
On Wed, Nov 23, 2022 at 11:35:32AM +0100, Martijn van Duren wrote: > On Wed, 2022-11-23 at 10:03 +, Klemens Nanni wrote: > > On Wed, Nov 23, 2022 at 10:48:22AM +0100, Martijn van Duren wrote: > > > On Wed, 2022-11-23 at 09:25 +, Klemens Nanni wrote: > > > > On Wed, Nov 23, 2022 at

Re: netstart(8): remove sed

2022-11-23 Thread Martijn van Duren
On Wed, 2022-11-23 at 10:03 +, Klemens Nanni wrote: > On Wed, Nov 23, 2022 at 10:48:22AM +0100, Martijn van Duren wrote: > > On Wed, 2022-11-23 at 09:25 +, Klemens Nanni wrote: > > > On Wed, Nov 23, 2022 at 10:15:20AM +0100, Martijn van Duren wrote: > > > > Here's an attempt to remove sed

Re: netstart(8): remove sed

2022-11-23 Thread Klemens Nanni
On Wed, Nov 23, 2022 at 10:48:22AM +0100, Martijn van Duren wrote: > On Wed, 2022-11-23 at 09:25 +, Klemens Nanni wrote: > > On Wed, Nov 23, 2022 at 10:15:20AM +0100, Martijn van Duren wrote: > > > Here's an attempt to remove sed from netstart. > > > > I don't see the point in this. > > On

Re: netstart(8): remove sed

2022-11-23 Thread Martijn van Duren
On Wed, 2022-11-23 at 09:25 +, Klemens Nanni wrote: > On Wed, Nov 23, 2022 at 10:15:20AM +0100, Martijn van Duren wrote: > > Here's an attempt to remove sed from netstart. > > I don't see the point in this. On Mon, 2022-11-21 at 20:42 -0700, Theo de Raadt wrote: > Oh, except that using grep,

Re: netstart(8): remove sed

2022-11-23 Thread Klemens Nanni
On Wed, Nov 23, 2022 at 10:15:20AM +0100, Martijn van Duren wrote: > Here's an attempt to remove sed from netstart. I don't see the point in this. > Since we use sed in a > simple string replacement without any fancy regex stuff I think we can > relatively easy use something based on shell

netstart(8): remove sed

2022-11-23 Thread Martijn van Duren
Here's an attempt to remove sed from netstart. Since we use sed in a simple string replacement without any fancy regex stuff I think we can relatively easy use something based on shell built-ins. Risk of the current code is that if someone places search inside replacement we get an infinite loop,