Re: ntpd offset loop refactoring

2021-04-21 Thread Claudio Jeker
On Tue, Apr 20, 2021 at 07:59:51PM +0200, Alexander Bluhm wrote: > I got a positive test report from Paul de Weerd. > > Anyone to ok it? OK claudio@ > On Thu, Mar 18, 2021 at 01:06:49PM +0100, Alexander Bluhm wrote: > > Hi, > > > > While hunting a bug in ntpd offset handling, I found some

Re: ntpd offset loop refactoring

2021-04-20 Thread Alexander Bluhm
I got a positive test report from Paul de Weerd. Anyone to ok it? On Thu, Mar 18, 2021 at 01:06:49PM +0100, Alexander Bluhm wrote: > Hi, > > While hunting a bug in ntpd offset handling, I found some things > that could be improved. > > Call the index of the offset loops "shift" consistently. >

ntpd offset loop refactoring

2021-03-18 Thread Alexander Bluhm
Hi, While hunting a bug in ntpd offset handling, I found some things that could be improved. Call the index of the offset loops "shift" consistently. Merge the two offset loops in client_update() into one. Assign the best value instead of memcpy. Use the same mechanism everywhere to avoid an