Re: ospf6d: remove unneded log_setverbose()

2018-07-09 Thread Claudio Jeker
On Mon, Jul 09, 2018 at 11:33:05AM +0200, Remi Locherer wrote: > On Mon, Jul 09, 2018 at 10:42:16AM +0200, Claudio Jeker wrote: > > On Mon, Jul 09, 2018 at 10:31:15AM +0200, Remi Locherer wrote: > > > later on it is set with: > > > log_setverbose(ospfd_conf->opts & OSPFD_OPT_VERBOSE); > > > > > >

Re: ospf6d: remove unneded log_setverbose()

2018-07-09 Thread Jeremie Courreges-Anglas
On Mon, Jul 09 2018, Remi Locherer wrote: > On Mon, Jul 09, 2018 at 10:42:16AM +0200, Claudio Jeker wrote: >> On Mon, Jul 09, 2018 at 10:31:15AM +0200, Remi Locherer wrote: >> > later on it is set with: >> > log_setverbose(ospfd_conf->opts & OSPFD_OPT_VERBOSE); >> > >> > OK? >> >> Shouldn't we

Re: ospf6d: remove unneded log_setverbose()

2018-07-09 Thread Remi Locherer
On Mon, Jul 09, 2018 at 10:42:16AM +0200, Claudio Jeker wrote: > On Mon, Jul 09, 2018 at 10:31:15AM +0200, Remi Locherer wrote: > > later on it is set with: > > log_setverbose(ospfd_conf->opts & OSPFD_OPT_VERBOSE); > > > > OK? > > Shouldn't we instead remove the log_setverbose(1) above the

Re: ospf6d: remove unneded log_setverbose()

2018-07-09 Thread Claudio Jeker
On Mon, Jul 09, 2018 at 10:31:15AM +0200, Remi Locherer wrote: > later on it is set with: > log_setverbose(ospfd_conf->opts & OSPFD_OPT_VERBOSE); > > OK? Shouldn't we instead remove the log_setverbose(1) above the getopt call? I think the idea is that we want to be able to print debug messages

ospf6d: remove unneded log_setverbose()

2018-07-09 Thread Remi Locherer
later on it is set with: log_setverbose(ospfd_conf->opts & OSPFD_OPT_VERBOSE); OK? Index: ospf6d.c === RCS file: /cvs/src/usr.sbin/ospf6d/ospf6d.c,v retrieving revision 1.35 diff -u -p -r1.35 ospf6d.c --- ospf6d.c5 Nov 2017