Hi tech@, Submitting patch to simplify code around free(3) in libssl. free() already handles the NULL case.
Does this look ok? - Michael Index: t1_enc.c =================================================================== RCS file: /cvs/src/lib/libssl/src/ssl/t1_enc.c,v retrieving revision 1.26 diff -u -r1.26 t1_enc.c --- t1_enc.c 21 Apr 2014 16:34:43 -0000 1.26 +++ t1_enc.c 24 Apr 2014 05:29:52 -0000 @@ -1141,10 +1141,8 @@ SSLerr(SSL_F_TLS1_EXPORT_KEYING_MATERIAL, ERR_R_MALLOC_FAILURE); rv = 0; ret: - if (buff != NULL) - free(buff); - if (val != NULL) - free(val); + free(buff); + free(val); return (rv); }