Re: pf: use proper interface for route-to when it is used with sticky-address

2019-07-10 Thread YASUOKA Masahiko
On Wed, 10 Jul 2019 23:50:23 +0100 Stuart Henderson wrote: > On 2019/07/10 23:27, Alexandr Nedvedicky wrote: >> Hello Stuart, >> >> On Wed, Jul 10, 2019 at 08:19:13PM +0100, Stuart Henderson wrote: >> > On 2019/07/05 17:09, YASUOKA Masahiko wrote: >> > > Hi, >> > > >> > > Previous diff made

Re: pf: use proper interface for route-to when it is used with sticky-address

2019-07-10 Thread Stuart Henderson
On 2019/07/10 23:27, Alexandr Nedvedicky wrote: > Hello Stuart, > > On Wed, Jul 10, 2019 at 08:19:13PM +0100, Stuart Henderson wrote: > > On 2019/07/05 17:09, YASUOKA Masahiko wrote: > > > Hi, > > > > > > Previous diff made src-node have a reference for the kif. My > > > colleague pointed out

Re: pf: use proper interface for route-to when it is used with sticky-address

2019-07-10 Thread Alexandr Nedvedicky
Hello Stuart, On Wed, Jul 10, 2019 at 08:19:13PM +0100, Stuart Henderson wrote: > On 2019/07/05 17:09, YASUOKA Masahiko wrote: > > Hi, > > > > Previous diff made src-node have a reference for the kif. My > > colleague pointed out that incrementing the reference count of the kif > > is required.

Re: pf: use proper interface for route-to when it is used with sticky-address

2019-07-10 Thread Stuart Henderson
On 2019/07/05 17:09, YASUOKA Masahiko wrote: > Hi, > > Previous diff made src-node have a reference for the kif. My > colleague pointed out that incrementing the reference count of the kif > is required. > > ok? > > Fix previous commit which made src-node have a reference for the kif. >

Re: pf: use proper interface for route-to when it is used with sticky-address

2019-07-08 Thread Alexandr Nedvedicky
Hello Yasuoka, > Previous diff made src-node have a reference for the kif. My > colleague pointed out that incrementing the reference count of the kif > is required. > > ok? > very good catch, indeed. Thanks for taking care of it. diff looks good to me. OK sashan

Re: pf: use proper interface for route-to when it is used with sticky-address

2019-07-05 Thread YASUOKA Masahiko
Hi, Previous diff made src-node have a reference for the kif. My colleague pointed out that incrementing the reference count of the kif is required. ok? Fix previous commit which made src-node have a reference for the kif. Src-node should use the reference counter since it might live longer

Re: pf: use proper interface for route-to when it is used with sticky-address

2019-07-01 Thread Alexandr Nedvedicky
Hello, On Mon, Jul 01, 2019 at 09:11:28PM +0900, YASUOKA Masahiko wrote: > Hi, > > "route-to" is used with the interface used for the next hop. But if > it is used with a source address track (sticky-address), it sometimes > output the packet to wrong interface. > > Example: > > pass in

pf: use proper interface for route-to when it is used with sticky-address

2019-07-01 Thread YASUOKA Masahiko
Hi, "route-to" is used with the interface used for the next hop. But if it is used with a source address track (sticky-address), it sometimes output the packet to wrong interface. Example: pass in quick inet proto tcp from any to 192.168.0.10 port 80 \ keep state (sloppy) route-to