Re: pf.conf(5) about queueing may be wrong

2021-08-23 Thread Stuart Henderson
On 2021/08/23 22:21, Klemens Nanni wrote:
> On Mon, Aug 23, 2021 at 07:03:45PM +0200, Solene Rapenne wrote:
> > pf.conf says this in QUEUEING
> > https://man.openbsd.org/pf.conf#QUEUEING
> > 
> > > If the referenced queue does not exist on the outgoing interface,
> > > the default queue for that interface is used.
> 
> This text is outdated, pfctl gained the below error in 2014 "shortly"
> after henning reworked queueing in 2013 to where that manual text dates
> back.
> 
> > however, with this simple config
> > 
> > queue std on re0 bandwidth 100M
> > queue lan parent std bandwidth 100M
> > queue internet parent std bandwidth 900K flows 512 default
> > match proto udp from em0:network to any port 53 queue dns
> > 
> > when reloading the file with pfctl, I get the following error:
> > /etc/pf.conf:27: queue dns is not defined
> > 
> > From the man page, I understand that if the queue used in match
> > doesn't exist, the default queue is used, as if "queue dns" wasn't
> > written in the rule.
> 
> Specified queues must exist, rules without `[set] queue ...' do use the
> default queue, obviously.
> 
> > Either the man page is wrong or not easy to understand, or the
> > parser is wrong.
> 
> OK kn to remove that sentence from the manual.
> 

Not ok with me.



Re: pf.conf(5) about queueing may be wrong

2021-08-23 Thread Stuart Henderson
On 2021/08/23 19:03, Solene Rapenne wrote:
> pf.conf says this in QUEUEING
> https://man.openbsd.org/pf.conf#QUEUEING
> 
> > If the referenced queue does not exist on the outgoing interface,
> > the default queue for that interface is used.
> 
> however, with this simple config
> 
> queue std on re0 bandwidth 100M
> queue lan parent std bandwidth 100M
> queue internet parent std bandwidth 900K flows 512 default
> match proto udp from em0:network to any port 53 queue dns
> 
> when reloading the file with pfctl, I get the following error:
> /etc/pf.conf:27: queue dns is not defined

In your config, the queue "dns" does not exist _at all_ in the config.

> From the man page, I understand that if the queue used in match
> doesn't exist, the default queue is used, as if "queue dns" wasn't
> written in the rule.

The manual talks about something a bit different, a queue that does
not exist _on a particular interface_.

> Either the man page is wrong or not easy to understand, or the
> parser is wrong.

I don't think it is wrong or even really hard to understand.



Re: pf.conf(5) about queueing may be wrong

2021-08-23 Thread Klemens Nanni
On Mon, Aug 23, 2021 at 07:03:45PM +0200, Solene Rapenne wrote:
> pf.conf says this in QUEUEING
> https://man.openbsd.org/pf.conf#QUEUEING
> 
> > If the referenced queue does not exist on the outgoing interface,
> > the default queue for that interface is used.

This text is outdated, pfctl gained the below error in 2014 "shortly"
after henning reworked queueing in 2013 to where that manual text dates
back.

> however, with this simple config
> 
> queue std on re0 bandwidth 100M
> queue lan parent std bandwidth 100M
> queue internet parent std bandwidth 900K flows 512 default
> match proto udp from em0:network to any port 53 queue dns
> 
> when reloading the file with pfctl, I get the following error:
> /etc/pf.conf:27: queue dns is not defined
> 
> From the man page, I understand that if the queue used in match
> doesn't exist, the default queue is used, as if "queue dns" wasn't
> written in the rule.

Specified queues must exist, rules without `[set] queue ...' do use the
default queue, obviously.

> Either the man page is wrong or not easy to understand, or the
> parser is wrong.

OK kn to remove that sentence from the manual.



pf.conf(5) about queueing may be wrong

2021-08-23 Thread Solene Rapenne
pf.conf says this in QUEUEING
https://man.openbsd.org/pf.conf#QUEUEING

> If the referenced queue does not exist on the outgoing interface,
> the default queue for that interface is used.

however, with this simple config

queue std on re0 bandwidth 100M
queue lan parent std bandwidth 100M
queue internet parent std bandwidth 900K flows 512 default
match proto udp from em0:network to any port 53 queue dns

when reloading the file with pfctl, I get the following error:
/etc/pf.conf:27: queue dns is not defined

From the man page, I understand that if the queue used in match
doesn't exist, the default queue is used, as if "queue dns" wasn't
written in the rule.

Either the man page is wrong or not easy to understand, or the
parser is wrong.