Re: pfctl: use mnemonic macros, terminate string with null char

2019-01-19 Thread Richard Procter
Hi, Comments below, > On 19/01/2019, at 2:32 PM, Klemens Nanni wrote: > > A few assorted nits for consistency and proper format, no object change. > > OK? > > Index: pfctl.c > === > RCS file: /cvs/src/sbin/pfctl/pfctl.c,v >

Re: pfctl: use mnemonic macros, terminate string with null char

2019-01-19 Thread Klemens Nanni
On Sat, Jan 19, 2019 at 05:14:56PM +1300, Richard Procter wrote: > > +#define PF_OPTIMIZE_NONE 0x > > these PF_OPTIMIZE_* are bit-field definitions, > see e.g. pfctl_optimize.c:299. While I'm aware of this, > But PF_OPTIMIZE_NONE is not, as pf->optimize & PF_OPTIMIZE_NONE > is never

pfctl: use mnemonic macros, terminate string with null char

2019-01-18 Thread Klemens Nanni
A few assorted nits for consistency and proper format, no object change. OK? Index: pfctl.c === RCS file: /cvs/src/sbin/pfctl/pfctl.c,v retrieving revision 1.365 diff -u -p -r1.365 pfctl.c --- pfctl.c 11 Jan 2019 03:09:24 -