Re: pkg_add testing

2018-12-16 Thread Marc Espie
On Wed, Dec 12, 2018 at 03:20:49PM +0100, Marc Espie wrote:
> Please test:
> 
> pkg_add -u -DSHORTENED

And Landry found an issue. I forgot to update some code when I tweaked stuff
to add @version support.

Please try again with just committed pkg_add code...

(basically, the older version didn't update some stuff it should have, so
you'll just have slightly more updates than before, shouldn't be harmful



pkg_add testing

2018-12-12 Thread Marc Espie
5 years agom I introduced a tweak to pkg_add to forego updates when they
weren't strictly necessary.  Then I made it the default.

This caused some unidentified problems at the time, and the code was
backed out by kili@ soon afterward.

I just *fixed* a weird bug in pkg_add, and there's a good chance it's directly
related: the bug would show up only when packages said "no need to update"
but leading to a shared library a few steps down in the chain of depends;
since the older tweak would lead to fewer updates, it would trigger the
bug more often.

So now is the time for testing that tweak again, see if it can become
default.

Please test:

pkg_add -u -DSHORTENED

will forego updates when the package being updated didn't really change
version (the update would only be triggered because the packages it was
built against were slightly newer, but the shared libraries would be the
same).

If nothing untowards happens, it probably means we nailed that 5 years old
problem...