Re: pppoe: start without kernel lock

2020-08-16 Thread Vitaliy Makkoveev
On Sun, Aug 16, 2020 at 08:44:07PM +0200, Klemens Nanni wrote: > On Sun, Aug 16, 2020 at 07:04:46PM +0200, Klemens Nanni wrote: > > Make sppp(4)/pppoe(4) use the ifq API to send packets outside the big > > lock. > > > > As far as I understand, pppoe_output() does not require NET_LOCK() since > >

Re: pppoe: start without kernel lock

2020-08-16 Thread Klemens Nanni
On Sun, Aug 16, 2020 at 07:04:46PM +0200, Klemens Nanni wrote: > Make sppp(4)/pppoe(4) use the ifq API to send packets outside the big > lock. > > As far as I understand, pppoe_output() does not require NET_LOCK() since > if_get(9)/if_put(9) guarantee the validity of the interface pointer and >

pppoe: start without kernel lock

2020-08-16 Thread Klemens Nanni
Make sppp(4)/pppoe(4) use the ifq API to send packets outside the big lock. As far as I understand, pppoe_output() does not require NET_LOCK() since if_get(9)/if_put(9) guarantee the validity of the interface pointer and no `struct ifnet' member is written to; similar to how vlan(4) does it.