Re: ps.1 tweak
Theo Buehler wrote: > On Thu, Oct 06, 2016 at 08:34:31PM +0100, Jason McIntyre wrote: > > On Thu, Oct 06, 2016 at 09:27:21PM +0200, Michal Mazurek wrote: > > > > > > Don't place a space after the minus sign. Change from this: > > > width in columns. Otherwise, ps defaults to the terminal width > > > - 1, or 79 columns if none of stdout, stderr and stdin are a > > > To this: > > > width in columns. Otherwise, ps defaults to the terminal width > > > -1, or 79 columns if none of stdout, stderr and stdin are a > > > > > > > i think it's correct as it is. you write 10 minus 7 as 10 - 7, not 10 -7, > > right? > > That's right, but the problem is an unfortunate line break in the > rendered page: > > COLUMNS If set to a positive integer, output is formatted to the given > width in columns. Otherwise, ps defaults to the terminal width > − 1, or 79 columns if none of stdout, stderr and stdin are a > terminal. > > I would suggest to just spell out '-' as minus. yes, and make the last part a new sentence. COLUMNS If set to a positive integer, output is formatted to the given width in columns. Otherwise, ps defaults to the terminal width minus 1. If none of stdout, stderr and stdin are a terminal, 79 columns are used.
Re: ps.1 tweak
I realised the text actually means to say "terminal width - 1", not "terminal width: -1" How about this instead? Index: bin/ps/ps.1 === RCS file: /cvs/src/bin/ps/ps.1,v retrieving revision 1.109 diff -u -p -r1.109 ps.1 --- bin/ps/ps.1 23 Sep 2016 06:28:08 - 1.109 +++ bin/ps/ps.1 6 Oct 2016 19:35:12 - @@ -543,7 +543,7 @@ If set to a positive integer, output is formatted to the given width in columns. Otherwise, .Nm -defaults to the terminal width \(mi 1, +defaults to the terminal width minus 1, or 79 columns if none of .Dv stdout , .Dv stderr -- Michal Mazurek
Re: ps.1 tweak
On Thu, Oct 06, 2016 at 08:34:31PM +0100, Jason McIntyre wrote: > On Thu, Oct 06, 2016 at 09:27:21PM +0200, Michal Mazurek wrote: > > > > Don't place a space after the minus sign. Change from this: > > width in columns. Otherwise, ps defaults to the terminal width > > - 1, or 79 columns if none of stdout, stderr and stdin are a > > To this: > > width in columns. Otherwise, ps defaults to the terminal width > > -1, or 79 columns if none of stdout, stderr and stdin are a > > > > i think it's correct as it is. you write 10 minus 7 as 10 - 7, not 10 -7, > right? That's right, but the problem is an unfortunate line break in the rendered page: COLUMNS If set to a positive integer, output is formatted to the given width in columns. Otherwise, ps defaults to the terminal width − 1, or 79 columns if none of stdout, stderr and stdin are a terminal. I would suggest to just spell out '-' as minus. > > jmc > > > Index: bin/ps/ps.1 > > === > > RCS file: /cvs/src/bin/ps/ps.1,v > > retrieving revision 1.109 > > diff -u -p -r1.109 ps.1 > > --- bin/ps/ps.1 23 Sep 2016 06:28:08 - 1.109 > > +++ bin/ps/ps.1 6 Oct 2016 19:24:51 - > > @@ -543,7 +543,7 @@ If set to a positive integer, > > output is formatted to the given width in columns. > > Otherwise, > > .Nm > > -defaults to the terminal width \(mi 1, > > +defaults to the terminal width \(mi1, > > or 79 columns if none of > > .Dv stdout , > > .Dv stderr > > > > -- > > Michal Mazurek > > >
Re: ps.1 tweak
On Thu, Oct 06, 2016 at 09:27:21PM +0200, Michal Mazurek wrote: > > Don't place a space after the minus sign. Change from this: > width in columns. Otherwise, ps defaults to the terminal width > - 1, or 79 columns if none of stdout, stderr and stdin are a > To this: > width in columns. Otherwise, ps defaults to the terminal width > -1, or 79 columns if none of stdout, stderr and stdin are a > i think it's correct as it is. you write 10 minus 7 as 10 - 7, not 10 -7, right? jmc > Index: bin/ps/ps.1 > === > RCS file: /cvs/src/bin/ps/ps.1,v > retrieving revision 1.109 > diff -u -p -r1.109 ps.1 > --- bin/ps/ps.1 23 Sep 2016 06:28:08 - 1.109 > +++ bin/ps/ps.1 6 Oct 2016 19:24:51 - > @@ -543,7 +543,7 @@ If set to a positive integer, > output is formatted to the given width in columns. > Otherwise, > .Nm > -defaults to the terminal width \(mi 1, > +defaults to the terminal width \(mi1, > or 79 columns if none of > .Dv stdout , > .Dv stderr > > -- > Michal Mazurek >
Re: ps.1 tweak
On Thu, Oct 06, 2016 at 09:27:21PM +0200, Michal Mazurek wrote: > > Don't place a space after the minus sign. Change from this: > width in columns. Otherwise, ps defaults to the terminal width > - 1, or 79 columns if none of stdout, stderr and stdin are a > To this: > width in columns. Otherwise, ps defaults to the terminal width > -1, or 79 columns if none of stdout, stderr and stdin are a I think it is more readable the way it was before. As I understand it the manpage doesn't refer to the constant '-1', but to 'terminal width minus 1', so the additional space makes sense to me. natano > > Index: bin/ps/ps.1 > === > RCS file: /cvs/src/bin/ps/ps.1,v > retrieving revision 1.109 > diff -u -p -r1.109 ps.1 > --- bin/ps/ps.1 23 Sep 2016 06:28:08 - 1.109 > +++ bin/ps/ps.1 6 Oct 2016 19:24:51 - > @@ -543,7 +543,7 @@ If set to a positive integer, > output is formatted to the given width in columns. > Otherwise, > .Nm > -defaults to the terminal width \(mi 1, > +defaults to the terminal width \(mi1, > or 79 columns if none of > .Dv stdout , > .Dv stderr > > -- > Michal Mazurek >
ps.1 tweak
Don't place a space after the minus sign. Change from this: width in columns. Otherwise, ps defaults to the terminal width - 1, or 79 columns if none of stdout, stderr and stdin are a To this: width in columns. Otherwise, ps defaults to the terminal width -1, or 79 columns if none of stdout, stderr and stdin are a Index: bin/ps/ps.1 === RCS file: /cvs/src/bin/ps/ps.1,v retrieving revision 1.109 diff -u -p -r1.109 ps.1 --- bin/ps/ps.1 23 Sep 2016 06:28:08 - 1.109 +++ bin/ps/ps.1 6 Oct 2016 19:24:51 - @@ -543,7 +543,7 @@ If set to a positive integer, output is formatted to the given width in columns. Otherwise, .Nm -defaults to the terminal width \(mi 1, +defaults to the terminal width \(mi1, or 79 columns if none of .Dv stdout , .Dv stderr -- Michal Mazurek
