Re: [External] : rework pfsync deferral timeout handling

2021-06-16 Thread Alexandr Nedvedicky
Hello, On Wed, Jun 16, 2021 at 02:19:24PM +1000, David Gwynne wrote: > > > > On 14 Jun 2021, at 19:12, Alexandr Nedvedicky > > wrote: > > > > Hello, > > > > looks good to me. I think this should be committed > > as-is. I have just one question, > > > > On Mon, Jun 14, 2021 at 01:58:06PM

Re: [External] : rework pfsync deferral timeout handling

2021-06-15 Thread David Gwynne
> On 14 Jun 2021, at 19:12, Alexandr Nedvedicky > wrote: > > Hello, > > looks good to me. I think this should be committed > as-is. I have just one question, > > On Mon, Jun 14, 2021 at 01:58:06PM +1000, David Gwynne wrote: > >> @@ -1931,6 +1933,9 @@ pfsync_defer(struct pf_state *st,

Re: [External] : rework pfsync deferral timeout handling

2021-06-14 Thread Alexandr Nedvedicky
Hello, looks good to me. I think this should be committed as-is. I have just one question, On Mon, Jun 14, 2021 at 01:58:06PM +1000, David Gwynne wrote: > @@ -1931,6 +1933,9 @@ pfsync_defer(struct pf_state *st, struct > { > struct pfsync_softc *sc = pfsyncif; > struct

rework pfsync deferral timeout handling

2021-06-13 Thread David Gwynne
pfsync deferrals are used so if you have firewalls that could both process packets, you defer sending the initial packet in state so the peer can learn about the state before potentially handling packets for it. there are three ways that a deferal can end. the preferred one is if a peer firewall