Re: rip sbappendaddr() with inpcb table mutex

2022-03-22 Thread Claudio Jeker
On Tue, Mar 22, 2022 at 06:35:47PM +0100, Alexander Bluhm wrote: > On Tue, Mar 22, 2022 at 04:42:45PM +0100, Claudio Jeker wrote: > > No but you push this layer into a specifc direction and by that make it > > harder to fix the PCB tables in a different way. I just see people > > changing the

Re: rip sbappendaddr() with inpcb table mutex

2022-03-22 Thread Alexander Bluhm
On Tue, Mar 22, 2022 at 04:42:45PM +0100, Claudio Jeker wrote: > No but you push this layer into a specifc direction and by that make it > harder to fix the PCB tables in a different way. I just see people > changing the NET_ASSERT_WLOCKED() without realizing the actual reason for > the exclusive

Re: rip sbappendaddr() with inpcb table mutex

2022-03-22 Thread Claudio Jeker
On Tue, Mar 22, 2022 at 02:56:43PM +0100, Alexander Bluhm wrote: > On Tue, Mar 22, 2022 at 02:25:08PM +0100, Claudio Jeker wrote: > > On Tue, Mar 22, 2022 at 02:09:51PM +0100, Alexander Bluhm wrote: > > > Hi, > > > > > > syzkaller and witness found the same bug I introduced in UDP also > > > for

Re: rip sbappendaddr() with inpcb table mutex

2022-03-22 Thread Alexander Bluhm
On Tue, Mar 22, 2022 at 02:25:08PM +0100, Claudio Jeker wrote: > On Tue, Mar 22, 2022 at 02:09:51PM +0100, Alexander Bluhm wrote: > > Hi, > > > > syzkaller and witness found the same bug I introduced in UDP also > > for Raw IP. Fix it the same was for rip and rip6. > > > >

Re: rip sbappendaddr() with inpcb table mutex

2022-03-22 Thread Claudio Jeker
On Tue, Mar 22, 2022 at 02:09:51PM +0100, Alexander Bluhm wrote: > Hi, > > syzkaller and witness found the same bug I introduced in UDP also > for Raw IP. Fix it the same was for rip and rip6. > > https://syzkaller.appspot.com/bug?extid=9bac6356a881dc644265 >

rip sbappendaddr() with inpcb table mutex

2022-03-22 Thread Alexander Bluhm
Hi, syzkaller and witness found the same bug I introduced in UDP also for Raw IP. Fix it the same was for rip and rip6. https://syzkaller.appspot.com/bug?extid=9bac6356a881dc644265 https://syzkaller.appspot.com/bug?extid=5b2679ee9be0895d26f9 ok? bluhm Index: netinet/raw_ip.c