Re: router timer mutex

2022-04-28 Thread Claudio Jeker
On Thu, Apr 28, 2022 at 07:24:22PM +0200, Alexander Bluhm wrote: > I still need an ok for this diff. It is the final step before we > can run IP forwaring in parallel. Fine with me. If it holds you back put it in OK claudio@ I will rip the rttimer code appart in the next days and make that API a

Re: router timer mutex

2022-04-28 Thread Alexander Bluhm
I still need an ok for this diff. It is the final step before we can run IP forwaring in parallel. bluhm On Thu, Apr 21, 2022 at 05:44:17PM +0200, Alexander Bluhm wrote: > On Wed, Apr 20, 2022 at 08:12:51PM +0200, Alexander Bluhm wrote: > > mvs@ reminded me of a crash I have seen in December.

Re: router timer mutex

2022-04-21 Thread Alexander Bluhm
On Wed, Apr 20, 2022 at 08:12:51PM +0200, Alexander Bluhm wrote: > mvs@ reminded me of a crash I have seen in December. Route timers > are not MP safe, but I think this can be fixed with a mutex. The > idea is to protect the global lists with a mutex and move the rttimer > into a temporary list.

Re: router timer mutex

2022-04-21 Thread Claudio Jeker
On Wed, Apr 20, 2022 at 08:12:51PM +0200, Alexander Bluhm wrote: > Hi, > > mvs@ reminded me of a crash I have seen in December. Route timers > are not MP safe, but I think this can be fixed with a mutex. The > idea is to protect the global lists with a mutex and move the rttimer > into a

Re: router timer mutex

2022-04-21 Thread Hrvoje Popovski
On 20.4.2022. 20:12, Alexander Bluhm wrote: > Hi, > > mvs@ reminded me of a crash I have seen in December. Route timers > are not MP safe, but I think this can be fixed with a mutex. The > idea is to protect the global lists with a mutex and move the rttimer > into a temporary list. Then the

router timer mutex

2022-04-20 Thread Alexander Bluhm
Hi, mvs@ reminded me of a crash I have seen in December. Route timers are not MP safe, but I think this can be fixed with a mutex. The idea is to protect the global lists with a mutex and move the rttimer into a temporary list. Then the callback and pool put can be called later without mutex.