Re: rpki-client: adjust HTTP/1.1 request string
On Fri, Jul 23, 2021 at 05:28:33PM +0200, Sebastian Benoit wrote: > Job Snijders(j...@openbsd.org) on 2021.07.23 15:23:49 +: > > Hi all, > > > > Based on suggestions from Julian Reschke. > > > > * "Connection: keep-alive" isn't needed, as the HTTP 1.1 default is to > > use persistent connections (RFC 7230, section 6.3). > > > > * "Host" is recommended to be in the front. > > > > * "Accept-Encoding: identity" makes it clear to the server compression > > encodings are not supported. > > https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Accept-Encoding > > > > OK? > > reasonable. > ok benno@ Agreed, I think the time of possible 'Connection: close' is over. The spec for Accept-Encoding is whako, the default is no-preference and therefor any encoding is OK. Who came up with such a bad default? Because of this OK claudio@ > > > > Kind regards, > > > > Job > > > > Index: http.c > > === > > RCS file: /cvs/src/usr.sbin/rpki-client/http.c,v > > retrieving revision 1.33 > > diff -u -p -r1.33 http.c > > --- http.c 10 May 2021 15:12:33 - 1.33 > > +++ http.c 23 Jul 2021 15:13:35 - > > @@ -847,9 +847,10 @@ http_request(struct http_connection *con > > conn->bufpos = 0; > > if ((r = asprintf(&conn->buf, > > "GET /%s HTTP/1.1\r\n" > > - "Connection: keep-alive\r\n" > > + "Host: %s\r\n" > > + "Accept-Encoding: identity\r\n" > > "User-Agent: " HTTP_USER_AGENT "\r\n" > > - "Host: %s\r\n%s\r\n", > > + "%s\r\n", > > epath, host, > > modified_since ? modified_since : "")) == -1) > > err(1, NULL); > > > -- :wq Claudio
Re: rpki-client: adjust HTTP/1.1 request string
Job Snijders(j...@openbsd.org) on 2021.07.23 15:23:49 +: > Hi all, > > Based on suggestions from Julian Reschke. > > * "Connection: keep-alive" isn't needed, as the HTTP 1.1 default is to > use persistent connections (RFC 7230, section 6.3). > > * "Host" is recommended to be in the front. > > * "Accept-Encoding: identity" makes it clear to the server compression > encodings are not supported. > https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Accept-Encoding > > OK? reasonable. ok benno@ > > Kind regards, > > Job > > Index: http.c > === > RCS file: /cvs/src/usr.sbin/rpki-client/http.c,v > retrieving revision 1.33 > diff -u -p -r1.33 http.c > --- http.c10 May 2021 15:12:33 - 1.33 > +++ http.c23 Jul 2021 15:13:35 - > @@ -847,9 +847,10 @@ http_request(struct http_connection *con > conn->bufpos = 0; > if ((r = asprintf(&conn->buf, > "GET /%s HTTP/1.1\r\n" > - "Connection: keep-alive\r\n" > + "Host: %s\r\n" > + "Accept-Encoding: identity\r\n" > "User-Agent: " HTTP_USER_AGENT "\r\n" > - "Host: %s\r\n%s\r\n", > + "%s\r\n", > epath, host, > modified_since ? modified_since : "")) == -1) > err(1, NULL); >
rpki-client: adjust HTTP/1.1 request string
Hi all, Based on suggestions from Julian Reschke. * "Connection: keep-alive" isn't needed, as the HTTP 1.1 default is to use persistent connections (RFC 7230, section 6.3). * "Host" is recommended to be in the front. * "Accept-Encoding: identity" makes it clear to the server compression encodings are not supported. https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Accept-Encoding OK? Kind regards, Job Index: http.c === RCS file: /cvs/src/usr.sbin/rpki-client/http.c,v retrieving revision 1.33 diff -u -p -r1.33 http.c --- http.c 10 May 2021 15:12:33 - 1.33 +++ http.c 23 Jul 2021 15:13:35 - @@ -847,9 +847,10 @@ http_request(struct http_connection *con conn->bufpos = 0; if ((r = asprintf(&conn->buf, "GET /%s HTTP/1.1\r\n" - "Connection: keep-alive\r\n" + "Host: %s\r\n" + "Accept-Encoding: identity\r\n" "User-Agent: " HTTP_USER_AGENT "\r\n" - "Host: %s\r\n%s\r\n", + "%s\r\n", epath, host, modified_since ? modified_since : "")) == -1) err(1, NULL);
