Re: rpki-client: provide more diagnostics to the operator

2023-05-11 Thread Job Snijders
On Thu, May 11, 2023 at 11:47:44AM +0200, Claudio Jeker wrote: > I'm not sure if this is quite right. > > valid_filehash() can be called twice first with the temp file and then > with the file from the valid repo. If the temp file has a bad hash then it > will result in a warning but the file

Re: rpki-client: provide more diagnostics to the operator

2023-05-11 Thread Claudio Jeker
On Thu, May 11, 2023 at 09:31:30AM +, Job Snijders wrote: > Hi Theo, > > On Wed, May 10, 2023 at 09:02:13PM +0200, Theo Buehler wrote: > > Again, try to keep the code as it was as far as possible. > > Indeed, thank you for the feedback! Below is an amended version. I'm not sure if this is

Re: rpki-client: provide more diagnostics to the operator

2023-05-11 Thread Job Snijders
Hi Theo, On Wed, May 10, 2023 at 09:02:13PM +0200, Theo Buehler wrote: > Again, try to keep the code as it was as far as possible. Indeed, thank you for the feedback! Below is an amended version. Kind regards, Job Index: extern.h

Re: rpki-client: provide more diagnostics to the operator

2023-05-10 Thread Theo Buehler
> $ doas rpki-client -t /etc/rpki/ripe.tal -H rpki.ripe.net -H > chloe.sobornost.net > rpki-client: > .rrdp/436FC6BD7B32853E42FCE5FD95B31D5E3EC1C32C46B7518C2067D568E7EAC119/chloe.sobornost.net/rpki/RIPE-nljobsnijders/cb/5EjPZ8Kw2_h5hRqKpwmjdnq7Tq8.roa: > bad file digest for

rpki-client: provide more diagnostics to the operator

2023-05-10 Thread Job Snijders
Hi folks, Without this changeset, rpki-client will display diagnostic information about missing files like so: $ doas rpki-client -t /etc/rpki/lacnic.tal -H repository.lacnic.net rpki-client: