Re: rthreads are always enabled

2013-04-05 Thread Philip Guenther
On Fri, Apr 5, 2013 at 7:49 PM, Ted Unangst wrote: > On Fri, Apr 05, 2013 at 15:35, Matthew Dempsky wrote: >>> - { "rthreads", CTLTYPE_INT }, \ >>> + { "rthreads", 0 }, \ >> >> Maybe change "rthreads" to "gap" like the other removed sysctl entries? > > So my thinking here is that "gap"

Re: rthreads are always enabled

2013-04-05 Thread Ted Unangst
On Fri, Apr 05, 2013 at 15:35, Matthew Dempsky wrote: > Maybe leave a comment that 74 was KERN_RTHREADS like for KERN_PROC? easy peasy. >> { "file2", CTLTYPE_STRUCT }, \ >> - { "rthreads", CTLTYPE_INT }, \ >> + { "rthreads", 0 }, \ > > Maybe change "rthreads" to "gap" like th

Re: rthreads are always enabled

2013-04-05 Thread Theo de Raadt
> I'm not sure about the sysctl change. Are we sure there isn't any > code out there that uses it? In that case we should hardcode it to 1. If there is code which uses it, that code is using a dead ABI. Things change, libraries are cranked, the past is left behind. That is our way.

Re: rthreads are always enabled

2013-04-05 Thread Philip Guenther
On Fri, Apr 5, 2013 at 3:34 PM, Mark Kettenis wrote: >> The small bits of code hiding behind rthreads_enabled aren't really >> experimental anymore. At this point, it's just one more knob you can >> twist to break your system. > > I'm not sure about the sysctl change. Are we sure there isn't any

Re: rthreads are always enabled

2013-04-05 Thread Matthew Dempsky
On Fri, Apr 5, 2013 at 3:26 PM, Ted Unangst wrote: > Index: sys/sysctl.h > === > RCS file: /cvs/src/sys/sys/sysctl.h,v > retrieving revision 1.131 > diff -u -p -r1.131 sysctl.h > --- sys/sysctl.h24 Mar 2013 00:09:31 -

Re: rthreads are always enabled

2013-04-05 Thread Mark Kettenis
> Date: Fri, 05 Apr 2013 18:26:32 -0400 > From: Ted Unangst > > The small bits of code hiding behind rthreads_enabled aren't really > experimental anymore. At this point, it's just one more knob you can > twist to break your system. I'm not sure about the sysctl change. Are we sure there isn't

rthreads are always enabled

2013-04-05 Thread Ted Unangst
The small bits of code hiding behind rthreads_enabled aren't really experimental anymore. At this point, it's just one more knob you can twist to break your system. Index: kern/kern_exit.c === RCS file: /cvs/src/sys/kern/kern_exit.c,