Re: scheduler small changes

2019-05-31 Thread Amit Kulkarni
> > > The only reason I added quantum, was that I stumbled on the round robin > > > interval buglet. Initially added a fixed 100 ms per proc, and then > > > decided how much I could explore this quantum idea while still trying to > > > keep the code understandable. > > > > Which buglet? Should

Re: scheduler small changes

2019-05-31 Thread Amit Kulkarni
Hi, Sorry for slacking off earlier, I was trying to recharge myself with some time off without looking at kernel code, and come back with a renewed focus. > > > Regarding the choice of deriving quantum from the priority, are you sure > > > the priorities are correct? Should we keep priorities?

Re: scheduler small changes

2019-05-17 Thread Alexandre Ratchov
On Wed, May 15, 2019 at 09:05:32AM -0500, Amit Kulkarni wrote: > > This diff survived multiple tens of kernel builds, a bsd.sp build, > bsd.rd build, a bsd.mp without these changes, userland/xenocara, a > make regress a few days ago all on 3 desktops on amd64. Ran under > all possible scenarios li

Re: scheduler small changes

2019-05-17 Thread Amit Kulkarni
On Thu, 16 May 2019 15:15:24 -0300 Martin Pieuchot wrote: > On 16/05/19(Thu) 00:08, Amit Kulkarni wrote: > > [...] > > > Regarding the choice of deriving quantum from the priority, are you sure > > > the priorities are correct? Should we keep priorities? Or if userland > > > needs priorities s

Re: scheduler small changes

2019-05-16 Thread Martin Pieuchot
On 16/05/19(Thu) 00:08, Amit Kulkarni wrote: > [...] > > Regarding the choice of deriving quantum from the priority, are you sure > > the priorities are correct? Should we keep priorities? Or if userland > > needs priorities shouldn't we convert quantum into priority and not the > > other way ar

Re: scheduler small changes

2019-05-15 Thread Solene Rapenne
On Wed, May 15, 2019 at 09:05:32AM -0500, Amit Kulkarni wrote: > Hi, > > This effort is heavily based on top of Gregor's and Michal's diffs. Tried to > incorporate feedback given by different people to them in 2011/2016. Split > the new code in a ifdef, so people can do a straight comparison, tr

Re: scheduler small changes

2019-05-15 Thread Amit Kulkarni
> Why did you decide to change the data structure of the runqueue? What > problem are you trying to solve? Thanks for your feedback. It forced me to do some introspection. I was trying to explore if we can tweak and make the current code faster, while still tryign to keep it as simple as it is

Re: scheduler small changes

2019-05-15 Thread Martin Pieuchot
Hello Amit, On 15/05/19(Wed) 09:05, Amit Kulkarni wrote: > Hi, > > This effort is heavily based on top of Gregor's and Michal's diffs. Tried to > incorporate feedback given by different people to them in 2011/2016. Split > the new code in a ifdef, so people can do a straight comparison, tried v

scheduler small changes

2019-05-15 Thread Amit Kulkarni
Hi, This effort is heavily based on top of Gregor's and Michal's diffs. Tried to incorporate feedback given by different people to them in 2011/2016. Split the new code in a ifdef, so people can do a straight comparison, tried very hard not to delete existing code, just shifted it around. Main