Re: sed(1): enable regression tests and correct pattern space assumptions

2022-01-10 Thread Todd C . Miller
OK millert@ - todd

Re: sed(1): enable regression tests and correct pattern space assumptions

2022-01-10 Thread Martijn van Duren
On Mon, 2022-01-10 at 08:21 -0700, Todd C. Miller wrote: > On Mon, 10 Jan 2022 15:23:42 +0100, Martijn van Duren wrote: > > > The lputs case is fairly straight forward and I'd like to get an OK > > for that part. > > I agree that fixing lputs() to honor psl is the best approach. > Wouldn't the

Re: sed(1): enable regression tests and correct pattern space assumptions

2022-01-10 Thread Todd C . Miller
On Mon, 10 Jan 2022 15:23:42 +0100, Martijn van Duren wrote: > The lputs case is fairly straight forward and I'd like to get an OK > for that part. I agree that fixing lputs() to honor psl is the best approach. Wouldn't the diff be simpler if you left the handling of 's' as-is but make the loop

Re: sed(1): enable regression tests and correct pattern space assumptions

2022-01-10 Thread Martijn van Duren
On Mon, 2022-01-10 at 00:25 -0600, user wrote: > The commandD1 regression test can be enabled without modifying sed's source > code, it is no longer failing. The commandl1, commandl2, and commandc1 tests > fail because the 'c' and 'D' commands assume that setting the correct length > of the