Re: sigabort(), p_sigmask & p_siglist

2020-09-16 Thread Miod Vallat
> Something doesn't feel right. > > db_kill_cmd finds a process, called p, then kills it. In your new diff > calling sigexit, take note of the comment at the top: > > * Force the current process to exit with the specified signal, dumping core > > current process? Doesn't look like it, it

Re: sigabort(), p_sigmask & p_siglist

2020-09-16 Thread Martin Pieuchot
On 16/09/20(Wed) 02:08, Theo de Raadt wrote: > Something doesn't feel right. > > db_kill_cmd finds a process, called p, then kills it. In your new diff > calling sigexit, take note of the comment at the top: > > * Force the current process to exit with the specified signal, dumping core > >

Re: sigabort(), p_sigmask & p_siglist

2020-09-16 Thread Theo de Raadt
Something doesn't feel right. db_kill_cmd finds a process, called p, then kills it. In your new diff calling sigexit, take note of the comment at the top: * Force the current process to exit with the specified signal, dumping core current process? Doesn't look like it, it looks like it kills

Re: sigabort(), p_sigmask & p_siglist

2020-09-16 Thread Martin Pieuchot
On 16/09/20(Wed) 06:09, Miod Vallat wrote: > > > Diff below introduces an helper for sending an uncatchable SIGABRT and > > annotate that `p_siglist' and `p_sigmask' are updated using atomic > > operations. > > Why not use sigexit(p, SIGABRT); for that purpose? That's a better solution indeed.

Re: sigabort(), p_sigmask & p_siglist

2020-09-16 Thread Miod Vallat
> Diff below introduces an helper for sending an uncatchable SIGABRT and > annotate that `p_siglist' and `p_sigmask' are updated using atomic > operations. Why not use sigexit(p, SIGABRT); for that purpose?

Re: sigabort(), p_sigmask & p_siglist

2020-09-15 Thread Claudio Jeker
On Tue, Sep 15, 2020 at 12:52:40PM +0200, Martin Pieuchot wrote: > Diff below introduces an helper for sending an uncatchable SIGABRT and > annotate that `p_siglist' and `p_sigmask' are updated using atomic > operations. > > As a result setsigvec() becomes local to kern/kern_sig.c. > > Note that

sigabort(), p_sigmask & p_siglist

2020-09-15 Thread Martin Pieuchot
Diff below introduces an helper for sending an uncatchable SIGABRT and annotate that `p_siglist' and `p_sigmask' are updated using atomic operations. As a result setsigvec() becomes local to kern/kern_sig.c. Note that other places in the kernel use sigexit(p, SIGABRT) for the same purpose and