Re: smtpd handling of \r in DATA part

2019-10-04 Thread Gilles Chehade
On Fri, Oct 04, 2019 at 10:09:06AM +0200, Martijn van Duren wrote: > On 10/4/19 10:03 AM, gil...@poolp.org wrote: > > October 4, 2019 9:55 AM, "Martijn van Duren" > > wrote: > >> > >> This is similar to the diff I send a few months ago, but still doesn't > >> fix the case when someone sends a

Re: smtpd handling of \r in DATA part

2019-10-04 Thread Martijn van Duren
On 10/4/19 10:03 AM, gil...@poolp.org wrote: > October 4, 2019 9:55 AM, "Martijn van Duren" > wrote: >> >> This is similar to the diff I send a few months ago, but still doesn't >> fix the case when someone sends a standalone '\n' as line-ending. >> > > Unsure I understand that, can you

Re: smtpd handling of \r in DATA part

2019-10-04 Thread gilles
October 4, 2019 9:55 AM, "Martijn van Duren" wrote: > > This is similar to the diff I send a few months ago, but still doesn't > fix the case when someone sends a standalone '\n' as line-ending. > Unsure I understand that, can you elaborate ? > I'd prefer if we go with reverting (=my

Re: smtpd handling of \r in DATA part

2019-10-04 Thread Martijn van Duren
On 10/4/19 9:36 AM, Gilles Chehade wrote: > On Fri, Oct 04, 2019 at 08:43:28AM +0200, Martijn van Duren wrote: annoying bumps will just be moved around. If we *really* want to fix this we need to make it fit within the specifications: [...] This means stop

Re: smtpd handling of \r in DATA part

2019-10-04 Thread Gilles Chehade
On Fri, Oct 04, 2019 at 08:43:28AM +0200, Martijn van Duren wrote: > >> annoying bumps will just be moved around. If we *really* want to fix > >> this we need to make it fit within the specifications: > >> > >> [...] > >> > >> This means stop opportunistic scanning for '\r' in iobuf! > >> > > > >

Re: smtpd handling of \r in DATA part

2019-10-04 Thread Martijn van Duren
On 10/4/19 8:23 AM, Gilles Chehade wrote: > On Fri, Oct 04, 2019 at 07:35:39AM +0200, Martijn van Duren wrote: >> On 10/3/19 9:05 PM, Eric Faurot wrote: >>> On Thu, Sep 19, 2019 at 05:48:17PM +, gil...@poolp.org wrote: >>> > To me, the only real problem with '\r' is at the end of lines.

Re: smtpd handling of \r in DATA part

2019-10-04 Thread Gilles Chehade
On Fri, Oct 04, 2019 at 07:35:39AM +0200, Martijn van Duren wrote: > On 10/3/19 9:05 PM, Eric Faurot wrote: > > On Thu, Sep 19, 2019 at 05:48:17PM +, gil...@poolp.org wrote: > > > >>> To me, the only real problem with '\r' is at the end of lines. It's > >>> confusing > >>> since you never

Re: smtpd handling of \r in DATA part

2019-10-03 Thread Martijn van Duren
On 10/3/19 9:05 PM, Eric Faurot wrote: > On Thu, Sep 19, 2019 at 05:48:17PM +, gil...@poolp.org wrote: > >>> To me, the only real problem with '\r' is at the end of lines. It's >>> confusing >>> since you never really know whether it's part of the content or the >>> protocol. >>> >>> So I

Re: smtpd handling of \r in DATA part

2019-10-03 Thread Eric Faurot
On Thu, Sep 19, 2019 at 05:48:17PM +, gil...@poolp.org wrote: > > To me, the only real problem with '\r' is at the end of lines. It's > > confusing > > since you never really know whether it's part of the content or the > > protocol. > > > > So I suggest that we strip all '\r' found at the

Re: smtpd handling of \r in DATA part

2019-09-20 Thread Martijn van Duren
On 9/19/19 5:46 PM, Gilles Chehade wrote: > Hello, > > The RFC for SMTP states the following (section 2.3.8): > > In addition, the appearance of "bare" "CR" or "LF" characters in text > (i.e., either without the other) has a long history of causing > problems in mail implementations

Re: smtpd handling of \r in DATA part

2019-09-19 Thread gilles
September 19, 2019 7:26 PM, "Eric Faurot" wrote: > On Thu, Sep 19, 2019 at 05:46:47PM +0200, Gilles Chehade wrote: > >> Hello, >> >> The RFC for SMTP states the following (section 2.3.8): >> >> In addition, the appearance of "bare" "CR" or "LF" characters in text >> (i.e., either without the

Re: smtpd handling of \r in DATA part

2019-09-19 Thread Eric Faurot
On Thu, Sep 19, 2019 at 05:46:47PM +0200, Gilles Chehade wrote: > Hello, > > The RFC for SMTP states the following (section 2.3.8): > > In addition, the appearance of "bare" "CR" or "LF" characters in text > (i.e., either without the other) has a long history of causing > problems in

smtpd handling of \r in DATA part

2019-09-19 Thread Gilles Chehade
Hello, The RFC for SMTP states the following (section 2.3.8): In addition, the appearance of "bare" "CR" or "LF" characters in text (i.e., either without the other) has a long history of causing problems in mail implementations and applications that use the mail system as a tool.