Re: smtpd.conf(5): comma in filter chains
> On 10 Apr 2016, at 08:49, Jason McIntyrewrote: > > fair enough. but since "..." already means optional i went further and > removed the []: > >filter name chain filter ... Ack. Thanks. David
Re: smtpd.conf(5): comma in filter chains
On Sun, Apr 10, 2016 at 08:08:21AM +0200, Joerg Jung wrote: > > > Am 09.04.2016 um 21:33 schrieb Jason McIntyre: > > > >> On Sat, Apr 09, 2016 at 11:42:58AM +0200, david+bsd@dahlberg.cologne wrote: > >> After quite some debugging of why the heck my smtpd.conf was not > >> working after upgrading to 5.9 and substituting clamsmtp and dkim- > >> signer by smtpd(8) filters: > >> > >> smtpd.conf(5) states: > >> ?? filter name chain filter [, ...] > >> but should say: > >> ?? filter name chain filter [...] > >> > > > > hi. > > > > could you explain what works and what doesn;t? from reading this, i'd > > expect the doc is trying to say you can specify one filter like this: > > > >filter x chain y > > > > and multiple filters: > > > >filter x chain y,z > > > > are you speciying one argument to "chain" or multiple? > > If read parse.y correctly filter x chain is allowed to have zero, one, or > multiple arguments. > Though, only multiple arguments really make sense here. > > The given multiple arguments need to be separated by spaces, not commas: > >filter x chain y z > > so I think the diff below is right. > fair enough. but since "..." already means optional i went further and removed the []: filter name chain filter ... jmc
Re: smtpd.conf(5): comma in filter chains
> Am 09.04.2016 um 21:33 schrieb Jason McIntyre: > >> On Sat, Apr 09, 2016 at 11:42:58AM +0200, david+bsd@dahlberg.cologne wrote: >> After quite some debugging of why the heck my smtpd.conf was not >> working after upgrading to 5.9 and substituting clamsmtp and dkim- >> signer by smtpd(8) filters: >> >> smtpd.conf(5) states: >> ?? filter name chain filter [, ...] >> but should say: >> ?? filter name chain filter [...] >> > > hi. > > could you explain what works and what doesn;t? from reading this, i'd > expect the doc is trying to say you can specify one filter like this: > >filter x chain y > > and multiple filters: > >filter x chain y,z > > are you speciying one argument to "chain" or multiple? If read parse.y correctly filter x chain is allowed to have zero, one, or multiple arguments. Though, only multiple arguments really make sense here. The given multiple arguments need to be separated by spaces, not commas: filter x chain y z so I think the diff below is right. > jmc > >> Index: smtpd.conf.5 >> === >> RCS file: /cvs/src/usr.sbin/smtpd/smtpd.conf.5,v >> retrieving revision 1.156 >> diff -u -p -r1.156 smtpd.conf.5 >> --- smtpd.conf.57 Mar 2016 16:21:48 -??1.156 >> +++ smtpd.conf.59 Apr 2016 09:32:23 - >> @@ -612,7 +612,7 @@ using the given filter >> ??Filters are used to hook into the SMTP dialog and provide additional >> filtering >> ??options for >> ??.Xr smtpd 8 . >> -.It Ic filter Ar name Ic chain Ar filter Op , Ar ... >> +.It Ic filter Ar name Ic chain Ar filter Op Ar ... >> ??Specify a filter chain with the given >> ??.Ar name >> ??and filters. >> >
Re: smtpd.conf(5): comma in filter chains
On Sat, Apr 09, 2016 at 11:42:58AM +0200, david+bsd@dahlberg.cologne wrote: > After quite some debugging of why the heck my smtpd.conf was not > working after upgrading to 5.9 and substituting clamsmtp and dkim- > signer by smtpd(8) filters: > > smtpd.conf(5) states: > ?? filter name chain filter [, ...] > but should say: > ?? filter name chain filter [...] > hi. could you explain what works and what doesn;t? from reading this, i'd expect the doc is trying to say you can specify one filter like this: filter x chain y and multiple filters: filter x chain y,z are you speciying one argument to "chain" or multiple? jmc > Index: smtpd.conf.5 > === > RCS file: /cvs/src/usr.sbin/smtpd/smtpd.conf.5,v > retrieving revision 1.156 > diff -u -p -r1.156 smtpd.conf.5 > --- smtpd.conf.57 Mar 2016 16:21:48 -??1.156 > +++ smtpd.conf.59 Apr 2016 09:32:23 - > @@ -612,7 +612,7 @@ using the given filter > ??Filters are used to hook into the SMTP dialog and provide additional > filtering > ??options for > ??.Xr smtpd 8 . > -.It Ic filter Ar name Ic chain Ar filter Op , Ar ... > +.It Ic filter Ar name Ic chain Ar filter Op Ar ... > ??Specify a filter chain with the given > ??.Ar name > ??and filters. >
smtpd.conf(5): comma in filter chains
After quite some debugging of why the heck my smtpd.conf was not working after upgrading to 5.9 and substituting clamsmtp and dkim- signer by smtpd(8) filters: smtpd.conf(5) states: filter name chain filter [, ...] but should say: filter name chain filter [...] Index: smtpd.conf.5 === RCS file: /cvs/src/usr.sbin/smtpd/smtpd.conf.5,v retrieving revision 1.156 diff -u -p -r1.156 smtpd.conf.5 --- smtpd.conf.57 Mar 2016 16:21:48 - 1.156 +++ smtpd.conf.59 Apr 2016 09:32:23 - @@ -612,7 +612,7 @@ using the given filter Filters are used to hook into the SMTP dialog and provide additional filtering options for .Xr smtpd 8 . -.It Ic filter Ar name Ic chain Ar filter Op , Ar ... +.It Ic filter Ar name Ic chain Ar filter Op Ar ... Specify a filter chain with the given .Ar name and filters.