Re: snmpd: tweak listen on

2021-11-21 Thread Martijn van Duren
On Sat, 2021-11-20 at 14:17 +, Stuart Henderson wrote: > On 2021/11/20 10:20, Martijn van Duren wrote: > > On Sun, 2021-11-14 at 22:30 +0100, Sebastian Benoit wrote: > > > If there is no obvious reason (i.e. be different because you need it for a > > > specific feature) why not to use the same

Re: snmpd: tweak listen on

2021-11-20 Thread Stuart Henderson
On 2021/11/20 10:20, Martijn van Duren wrote: > On Sun, 2021-11-14 at 22:30 +0100, Sebastian Benoit wrote: > > If there is no obvious reason (i.e. be different because you need it for a > > specific feature) why not to use the same host*() function as other parse.y? > > it would be better to stay i

Re: snmpd: tweak listen on

2021-11-20 Thread Martijn van Duren
On Sun, 2021-11-14 at 22:30 +0100, Sebastian Benoit wrote: > If there is no obvious reason (i.e. be different because you need it for a > specific feature) why not to use the same host*() function as other parse.y? > it would be better to stay in sync with otehrr daemons. That way if there is > an

Re: snmpd: tweak listen on

2021-11-14 Thread Theo de Raadt
Yes, whereas Martijn's proposal changes *all programs immediately*, and would require a lot of inspection for downside impacts. > If there is no obvious reason (i.e. be different because you need it for a > specific feature) why not to use the same host*() function as other parse.y? > it would be

Re: snmpd: tweak listen on

2021-11-14 Thread Sebastian Benoit
If there is no obvious reason (i.e. be different because you need it for a specific feature) why not to use the same host*() function as other parse.y? it would be better to stay in sync with otehrr daemons. That way if there is an issue in one daemon, we can fix it in all of them. Or, to turn the

Re: snmpd: tweak listen on

2021-11-13 Thread Martijn van Duren
On Sat, 2021-11-13 at 13:23 +, Stuart Henderson wrote: > On 2021/08/09 20:55, Martijn van Duren wrote: > > On Mon, 2021-08-09 at 11:57 +0200, Martijn van Duren wrote: > > > > > > This diff fixes all of the above: > > > - Allow any to be used resolving to 0.0.0.0 and :: > > > - Set SO_REUSEADDR

Re: snmpd: tweak listen on

2021-11-13 Thread Theo de Raadt
Stuart Henderson wrote: > On 2021/08/09 20:55, Martijn van Duren wrote: > > On Mon, 2021-08-09 at 11:57 +0200, Martijn van Duren wrote: > > > > > > This diff fixes all of the above: > > > - Allow any to be used resolving to 0.0.0.0 and :: > > > - Set SO_REUSEADDR on sockets, so we can listen on

Re: snmpd: tweak listen on

2021-11-13 Thread Stuart Henderson
On 2021/08/09 20:55, Martijn van Duren wrote: > On Mon, 2021-08-09 at 11:57 +0200, Martijn van Duren wrote: > > > > This diff fixes all of the above: > > - Allow any to be used resolving to 0.0.0.0 and :: > > - Set SO_REUSEADDR on sockets, so we can listen on both any and > >   localhost > > - Doc

Re: snmpd: tweak listen on

2021-08-09 Thread Stuart Henderson
On 2021/08/09 20:55, Martijn van Duren wrote: > Updated diff after my engineid commit. ok > Index: snmpd.conf.5 > === > RCS file: /cvs/src/usr.sbin/snmpd/snmpd.conf.5,v > retrieving revision 1.53 > diff -u -p -r1.53 snmpd.conf.5 > --

Re: snmpd: tweak listen on

2021-08-09 Thread Martijn van Duren
On Mon, 2021-08-09 at 11:57 +0200, Martijn van Duren wrote: > On Sun, 2021-08-08 at 14:44 +0100, Stuart Henderson wrote: > > > This is probably is a bad example. > > > Reading it like this: you're correct that we listen on all interfaces > > > by default, but that's not listed in snmpd.conf(5). So

snmpd: tweak listen on

2021-08-09 Thread Martijn van Duren
On Sun, 2021-08-08 at 14:44 +0100, Stuart Henderson wrote: > > This is probably is a bad example. > > Reading it like this: you're correct that we listen on all interfaces > > by default, but that's not listed in snmpd.conf(5). So that should > > probably be fixed (including mentioning that setting