Re: ssh/sshd change in snaps

2021-11-16 Thread Damien Miller
On Wed, 17 Nov 2021, Damien Miller wrote:

> On Tue, 16 Nov 2021, Damien Miller wrote:
> 
> > Another couple of fixes in tomorrow's snaps. One to avoid errors like:
> > 
> > > channel 3: chan_read_failed for istate 3
> > 
> > Another avoids a situation where sshd could get stuck spinning on poll()
> > if it fails.
> > 
> > (Both uncovered by web browsing through a SOCKS dynamic forwarder)
> 
> BTW I have uploaded the diff for this change to github in case anyone
> is curious:
> 
> https://patch-diff.githubusercontent.com/raw/djmdjm/openssh-wip/pull/6

sorry, bad link. Correct one is:

https://github.com/djmdjm/openssh-wip/pull/6.diff
https://github.com/djmdjm/openssh-wip/pull/6



Re: ssh/sshd change in snaps

2021-11-16 Thread Damien Miller
On Tue, 16 Nov 2021, Damien Miller wrote:

> Another couple of fixes in tomorrow's snaps. One to avoid errors like:
> 
> > channel 3: chan_read_failed for istate 3
> 
> Another avoids a situation where sshd could get stuck spinning on poll()
> if it fails.
> 
> (Both uncovered by web browsing through a SOCKS dynamic forwarder)

BTW I have uploaded the diff for this change to github in case anyone
is curious:

https://patch-diff.githubusercontent.com/raw/djmdjm/openssh-wip/pull/6

or in patch(1) format:

https://patch-diff.githubusercontent.com/raw/djmdjm/openssh-wip/pull/6.diff



Re: ssh/sshd change in snaps

2021-11-15 Thread Damien Miller
On Sat, 13 Nov 2021, Damien Miller wrote:

> On Thu, 11 Nov 2021, Damien Miller wrote:
> 
> > Hi,
> > 
> > Snaps is now carrying a change to ssh/sshd that converts their
> > mainloops from select(2) to poll/ppoll(2). This change should be
> > completely transparent, but please be on the lookout for any weird
> > behaviour. Bugs in the revised mainloop are most likely to appear
> > as crashes, hangs or ssh/sshd using lots of CPU when idle.
> > 
> > Please report anything you see here, to openssh@ or to me.
> 
> FYI this has gone through one interation of bugfixes since it first went
> in. If you are running a snap from yesterday and experience problems then
> please upgrade to a newer one and retest.

Another couple of fixes in tomorrow's snaps. One to avoid errors like:

> channel 3: chan_read_failed for istate 3

Another avoids a situation where sshd could get stuck spinning on poll()
if it fails.

(Both uncovered by web browsing through a SOCKS dynamic forwarder)

-d



Re: ssh/sshd change in snaps

2021-11-12 Thread Damien Miller
On Thu, 11 Nov 2021, Damien Miller wrote:

> Hi,
> 
> Snaps is now carrying a change to ssh/sshd that converts their
> mainloops from select(2) to poll/ppoll(2). This change should be
> completely transparent, but please be on the lookout for any weird
> behaviour. Bugs in the revised mainloop are most likely to appear
> as crashes, hangs or ssh/sshd using lots of CPU when idle.
> 
> Please report anything you see here, to openssh@ or to me.

FYI this has gone through one interation of bugfixes since it first went
in. If you are running a snap from yesterday and experience problems then
please upgrade to a newer one and retest.

-d



ssh/sshd change in snaps

2021-11-10 Thread Damien Miller
Hi,

Snaps is now carrying a change to ssh/sshd that converts their
mainloops from select(2) to poll/ppoll(2). This change should be
completely transparent, but please be on the lookout for any weird
behaviour. Bugs in the revised mainloop are most likely to appear
as crashes, hangs or ssh/sshd using lots of CPU when idle.

Please report anything you see here, to openssh@ or to me.

Thanks,
Damien