Re: ssh: Register tun channel cleanup callback when ExitOnForwardFailure is set

2020-02-17 Thread Remi Pommarel
On Tue, Feb 18, 2020 at 09:00:13AM +1100, Damien Miller wrote: > On Mon, 17 Feb 2020, Remi Pommarel wrote: > > > When remote side fails to create tun (e.g. tun device is already opened) > > it notifies the client with an SSH2_MSG_CHANNEL_OPEN_FAILURE message and > > channel is marked dead on

Re: ssh: Register tun channel cleanup callback when ExitOnForwardFailure is set

2020-02-17 Thread Damien Miller
On Mon, 17 Feb 2020, Remi Pommarel wrote: > When remote side fails to create tun (e.g. tun device is already opened) > it notifies the client with an SSH2_MSG_CHANNEL_OPEN_FAILURE message and > channel is marked dead on client side. But because tun forward channel > is not an interactive channel

ssh: Register tun channel cleanup callback when ExitOnForwardFailure is set

2020-02-17 Thread Remi Pommarel
When remote side fails to create tun (e.g. tun device is already opened) it notifies the client with an SSH2_MSG_CHANNEL_OPEN_FAILURE message and channel is marked dead on client side. But because tun forward channel is not an interactive channel it has no cleanup callback and is kept in a Zombie