Re: ssh-add(1): fix NULL in fprintf

2022-06-17 Thread Darren Tucker
On Fri, 17 Jun 2022 at 04:49, Martin Vahlensieck wrote: > ping, diff attached Applied, thanks. -- Darren Tucker (dtucker at dtucker.net) GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new) Good judgement comes with experience. Unfortunately, the experience usually

Re: ssh-add(1): fix NULL in fprintf

2022-06-16 Thread Martin Vahlensieck
ping, diff attached On Mon, May 16, 2022 at 09:21:42PM +0200, Martin Vahlensieck wrote: > Hi > > What's the status on this? Anthing required from my side? I have > reattached the patch (with the changes Theo suggested). > > Best, > > Martin > > On Mon, May 09, 2022 at 08:39:38PM +0200,

Re: ssh-add(1): fix NULL in fprintf

2022-05-16 Thread Martin Vahlensieck
Hi What's the status on this? Anthing required from my side? I have reattached the patch (with the changes Theo suggested). Best, Martin On Mon, May 09, 2022 at 08:39:38PM +0200, Martin Vahlensieck wrote: > On Mon, May 09, 2022 at 10:42:29AM -0600, Theo de Raadt wrote: > > Martin Vahlensieck

Re: ssh-add(1): fix NULL in fprintf

2022-05-09 Thread Martin Vahlensieck
On Mon, May 09, 2022 at 10:42:29AM -0600, Theo de Raadt wrote: > Martin Vahlensieck wrote: > > > if (!qflag) { > > - fprintf(stderr, "Identity removed: %s %s (%s)\n", path, > > - sshkey_type(key), comment); > > + fprintf(stderr, "Identity removed: %s

Re: ssh-add(1): fix NULL in fprintf

2022-05-09 Thread Theo de Raadt
Martin Vahlensieck wrote: > if (!qflag) { > - fprintf(stderr, "Identity removed: %s %s (%s)\n", path, > - sshkey_type(key), comment); > + fprintf(stderr, "Identity removed: %s %s%s%s%s\n", path, > + sshkey_type(key), comment ? " (" :

ssh-add(1): fix NULL in fprintf

2022-05-09 Thread Martin Vahlensieck
Hi When removing an identity from the agent using the private key file, ssh-add first tries to find the public key file. If that fails, it loads the public key from the private key file, but no comment is loaded. This means comment is NULL when it is used inside delete_one to print `Identity