Re: sshd(8) logging of client disconnect from ClientAliveInterval

2017-12-09 Thread Lars Nooden
On Wed, 18 Oct 2017, Darren Tucker wrote: > I meant reusing the existing function rather than cloning it. It's > currently static so it needs to be exported but IMO that's better than > duplicating the code. > > Index: packet.c > ===

Re: sshd(8) logging of client disconnect from ClientAliveInterval

2017-10-17 Thread Damien Miller
ok by me On Wed, 18 Oct 2017, Darren Tucker wrote: > On Tue, Oct 17, 2017 at 09:10:38PM +0300, Lars Noodén wrote: > > Here is a replacement patch. > > I meant reusing the existing function rather than cloning it. It's > currently static so it needs to be exported but IMO that's better than > du

Re: sshd(8) logging of client disconnect from ClientAliveInterval

2017-10-17 Thread Darren Tucker
On Tue, Oct 17, 2017 at 09:10:38PM +0300, Lars Noodén wrote: > Here is a replacement patch. I meant reusing the existing function rather than cloning it. It's currently static so it needs to be exported but IMO that's better than duplicating the code. Index: packet.c

Re: sshd(8) logging of client disconnect from ClientAliveInterval

2017-10-17 Thread Lars Noodén
Here is a replacement patch. /Lars Index: serverloop.c === RCS file: /cvs/src/usr.bin/ssh/serverloop.c,v retrieving revision 1.198 diff -u -p -u -r1.198 serverloop.c --- serverloop.c12 Sep 2017 06:35:32 - 1.198 +++ s

Re: sshd(8) logging of client disconnect from ClientAliveInterval

2017-10-17 Thread Lars Noodén
On 10/17/17, Darren Tucker wrote: [snip] > probably better to use fmt_connection_id() instead of hand-rolling the > format. Ok. I have added fmt_connection_id() to serverloop.c from packet.c /Lars Index: src/usr.bin/ssh/serverloop.c =

Re: sshd(8) logging of client disconnect from ClientAliveInterval

2017-10-16 Thread Darren Tucker
On 17 October 2017 at 06:04, Lars Noodén wrote: > > + logit("Timeout, client not responding from %s on port %d.", > + ssh_remote_ipaddr(ssh), ssh_remote_port(ssh) ); > probably better to use fmt_connection_id() instead of hand-rolling the format. -- Darren Tucker (dt

sshd(8) logging of client disconnect from ClientAliveInterval

2017-10-16 Thread Lars Noodén
sshd(8) used to log connection information when ClientAliveInterval disconnected an idle client. It used to look something like this a while back: Oct 16 14:42:08 eee sshd[83709]: packet_write_poll: Connection from 192.0.2.97 port 57608: Host is down Now it looks like this: