Re: sysctl fix

2013-06-09 Thread Ted Unangst
On Thu, Jun 06, 2013 at 23:58, Sylvestre Gallon wrote: Here is a second one to add fuse sysctls. +#define FUSEFS_NB_OPENDEVS 1 /* # of fuse devices opened */ Applied, except I changed this to FUSEFS_OPENDEVS, which seemed a little simpler. Thanks.

sysctl fix

2013-06-06 Thread Sylvestre Gallon
Hi tech@ I was currently trying to get the fuse sysctls working when I found a bug in sbin/sysctl.c If you look at sys/kern/vfs_init.c MOUNT_FUSEFS use the biggest typenum : 18. So when the function vfsinit in sbin/sysctl.c gets VFS_MAXTYPENUM it gets 18, but this value will never be reached in

Re: sysctl fix

2013-06-06 Thread Alexey E. Suslikov
Sylvestre Gallon ccna.syl at gmail.com writes: at at -2586,6 +2587,7 at at struct emulname { } *emul_names; int emul_num, nemuls; int emul_init(void); +int emulcmp(const void *, const void *); this seems unrelated to rest of changes you've made. no?

Re: sysctl fix

2013-06-06 Thread Sylvestre Gallon
On Thu, Jun 6, 2013 at 4:39 PM, Alexey E. Suslikov alexey.susli...@gmail.com wrote: int emulcmp(const void *, const void *); using WARNINGS=yes make it remove the following warning : sysctl.c:2697: warning: no previous prototype for 'emulcmp' Cheers, -- Sylvestre Gallon

Re: sysctl fix

2013-06-06 Thread Ted Unangst
On Thu, Jun 06, 2013 at 15:39, Sylvestre Gallon wrote: Hi tech@ I was currently trying to get the fuse sysctls working when I found a bug in sbin/sysctl.c If you look at sys/kern/vfs_init.c MOUNT_FUSEFS use the biggest typenum : 18. So when the function vfsinit in sbin/sysctl.c gets

Re: sysctl fix

2013-06-06 Thread Ted Unangst
On Thu, Jun 06, 2013 at 11:42, patrick keshishian wrote: Just curious, how do the variable name changes help any warrnings? nflag - nf -Wshadow. nflag is a global, which becomes hidden by giving a local parameter the same name. The code is kind of silly anyway, since the only call to that

Re: sysctl fix

2013-06-06 Thread Sylvestre Gallon
Hi, Sorry for the last mistakes. Here is a new diff that allow the maxtypenum to be reached. Cheers, Index: sysctl.c === RCS file: /cvs/src/sbin/sysctl/sysctl.c,v retrieving revision 1.189 diff -u -p -r1.189 sysctl.c --- sysctl.c

Re: sysctl fix

2013-06-06 Thread Sylvestre Gallon
Here is a second one to add fuse sysctls. Cheers, Index: sys/miscfs/fuse/fusefs.h === RCS file: /cvs/src/sys/miscfs/fuse/fusefs.h,v retrieving revision 1.1 diff -u -p -r1.1 fusefs.h --- sys/miscfs/fuse/fusefs.h3 Jun 2013

Re: sysctl fix

2013-06-06 Thread Sylvestre Gallon
And here the third one that removes all warns for : WARNINGS=yes make Cheers, Index: sysctl.c === RCS file: /cvs/src/sbin/sysctl/sysctl.c,v retrieving revision 1.189 diff -u -p -u -p -r1.189 sysctl.c --- sysctl.c16 Apr 2013

Re: sysctl fix

2013-06-06 Thread Ted Unangst
On Thu, Jun 06, 2013 at 15:39, Sylvestre Gallon wrote: If you look at sys/kern/vfs_init.c MOUNT_FUSEFS use the biggest typenum : 18. So when the function vfsinit in sbin/sysctl.c gets VFS_MAXTYPENUM it gets 18, but this value will never be reached in the for statement... The diff below

Re: sysctl fix

2013-06-06 Thread Ted Unangst
On Thu, Jun 06, 2013 at 23:53, Sylvestre Gallon wrote: Hi, Sorry for the last mistakes. Here is a new diff that allow the maxtypenum to be reached. Cheers, Index: sysctl.c === RCS file: /cvs/src/sbin/sysctl/sysctl.c,v