Re: tcpdump: stop building SLIP support

2015-11-04 Thread Jérémie Courrèges-Anglas 
Theo de Raadt  writes:

> Why?
>
> We don't have decnet code either, yet it is nice to sniff it if you
> see it.

My understanding was that since sl(4) is gone, there's no way to have an
interface configured with SLIP on OpenBSD, thus no way to see that
protocol and no way to reach that code.  I'm also looking at the useless
DLT_SLIP occurrence in net/bpf.c.  Or am I missing something?

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Re: tcpdump: stop building SLIP support

2015-11-04 Thread Stuart Henderson 
On 2015/11/04 19:41, Jérémie Courrèges-Anglas wrote:
> 
> Some time ago mpi removed the sl(4) driver, IIUC this makes a bunch of
> code useless in tcpdump.

It still has slight use for pcap files generated on another system..

Re: tcpdump: stop building SLIP support

2015-11-04 Thread Theo de Raadt 
Why?

We don't have decnet code either, yet it is nice to sniff it if you
see it.

> Some time ago mpi removed the sl(4) driver, IIUC this makes a bunch of
> code useless in tcpdump.
> 
> The diff below only removes the define.  If people prefer, I could also
> kill some noise by removing the useless code in print-sl.c, leaving only
> the stub functions.
> 
> Comments / ok?
> 
> Index: Makefile
> ===
> RCS file: /cvs/src/usr.sbin/tcpdump/Makefile,v
> retrieving revision 1.59
> diff -u -p -p -u -r1.59 Makefile
> --- Makefile  14 Oct 2015 04:55:17 -  1.59
> +++ Makefile  4 Nov 2015 18:05:23 -
> @@ -28,7 +28,7 @@ CFLAGS+=-Wall -I${.CURDIR}/../../sbin/pf
>  # for pcap-int.h
>  CFLAGS+=-I${.CURDIR}/../../lib/libpcap
>  
> -CFLAGS+=-DCSLIP -DPPP -DHAVE_FDDI -DETHER_SERVICE -DHAVE_NET_SLIP_H 
> -DHAVE_ETHER_NTOHOST -DINET6
> +CFLAGS+=-DCSLIP -DPPP -DHAVE_FDDI -DETHER_SERVICE -DHAVE_ETHER_NTOHOST 
> -DINET6
>  
>  LDADD+=  -lpcap -ll -lcrypto
>  DPADD+=  ${LIBL} ${LIBPCAP} ${LIBCRYPTO}
> 
> 
> -- 
> jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE
>

tcpdump: stop building SLIP support

2015-11-04 Thread Jérémie Courrèges-Anglas 

Some time ago mpi removed the sl(4) driver, IIUC this makes a bunch of
code useless in tcpdump.

The diff below only removes the define.  If people prefer, I could also
kill some noise by removing the useless code in print-sl.c, leaving only
the stub functions.

Comments / ok?

Index: Makefile
===
RCS file: /cvs/src/usr.sbin/tcpdump/Makefile,v
retrieving revision 1.59
diff -u -p -p -u -r1.59 Makefile
--- Makefile14 Oct 2015 04:55:17 -  1.59
+++ Makefile4 Nov 2015 18:05:23 -
@@ -28,7 +28,7 @@ CFLAGS+=-Wall -I${.CURDIR}/../../sbin/pf
 # for pcap-int.h
 CFLAGS+=-I${.CURDIR}/../../lib/libpcap
 
-CFLAGS+=-DCSLIP -DPPP -DHAVE_FDDI -DETHER_SERVICE -DHAVE_NET_SLIP_H 
-DHAVE_ETHER_NTOHOST -DINET6
+CFLAGS+=-DCSLIP -DPPP -DHAVE_FDDI -DETHER_SERVICE -DHAVE_ETHER_NTOHOST -DINET6
 
 LDADD+=-lpcap -ll -lcrypto
 DPADD+=${LIBL} ${LIBPCAP} ${LIBCRYPTO}


-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE