> 1) our dirent entries are now 8 byte aligned
> 2) d_type isn't the file's st_mode, but rather a type that can be derived
>    from the file's mode
> 3) the readdir callback should be setting d_off, but to what?  this diff
>    just assumes fuse-based filesystems can operate with length based
>    offsets (even though the padding of them is changed by (1) above!); is
>    this a bug in the FUSE API?

My bad, I forgot to set d_off when implementing the fuse_fill_readdir.

> 4) (no binary change) if the file type is unknown, use DT_UNKNOWN
>    explictly instead of assuming that's equal to zero
>
> (Do FUSE filesystems just not support telldir/seekdir?)

The GNU libfuse seems to not handle them. But we can fix our lib to fix that.

>
> oks?

You're diff works for me OK syl@


-- 
Sylvestre Gallon

Reply via email to