Re: upd(4) buggy firmware

2014-12-11 Thread Martin Pieuchot
On 09/12/14(Tue) 10:57, David Higgs wrote: On Dec 8, 2014, at 6:07 PM, Martin Pieuchot mpieuc...@nolizard.org wrote: On 08/12/14(Mon) 09:35, David Higgs wrote: On Mon, Dec 8, 2014 at 9:29 AM, Martin Pieuchot mpieuc...@nolizard.org wrote: [...] Now I'd like to finish the transition

Re: upd(4) buggy firmware

2014-12-11 Thread Mark Kettenis
Date: Thu, 11 Dec 2014 12:22:56 +0100 From: Martin Pieuchot mpieuc...@nolizard.org Index: ucycom.c === RCS file: /home/ncvs/src/sys/dev/usb/ucycom.c,v retrieving revision 1.29 diff -u -p -r1.29 ucycom.c --- ucycom.c 12 Jul

Re: upd(4) buggy firmware

2014-12-11 Thread Martin Pieuchot
On 11/12/14(Thu) 12:48, Mark Kettenis wrote: Date: Thu, 11 Dec 2014 12:22:56 +0100 From: Martin Pieuchot mpieuc...@nolizard.org Index: ucycom.c === RCS file: /home/ncvs/src/sys/dev/usb/ucycom.c,v retrieving revision

Re: upd(4) buggy firmware

2014-12-11 Thread David Higgs
On Thu, Dec 11, 2014 at 6:22 AM, Martin Pieuchot mpieuc...@nolizard.org wrote: Thanks for all your comments. I though a bit more about this change and decided to: - Simply return the number of bytes written/read upon success and -1 otherwise (à la read/write). This allows us to remove

Re: upd(4) buggy firmware

2014-12-09 Thread David Higgs
On Dec 8, 2014, at 6:07 PM, Martin Pieuchot mpieuc...@nolizard.org wrote: On 08/12/14(Mon) 09:35, David Higgs wrote: On Mon, Dec 8, 2014 at 9:29 AM, Martin Pieuchot mpieuc...@nolizard.org wrote: [...] Now I'd like to finish the transition that started with the import of upd(4) and move

Re: upd(4) buggy firmware

2014-12-08 Thread David Higgs
On Sat, Dec 6, 2014 at 8:57 AM, Martin Pieuchot mpieuc...@nolizard.org wrote: The ohci(4) diff is almost fine, USBD_SHORT_XFER should only be set in usbd_transfer_complete() so the HCD should only set the status to USBD_NORMAL_COMPLETION, see below. Concerning your broken firmware, what we

Re: upd(4) buggy firmware

2014-12-08 Thread Martin Pieuchot
On 08/12/14(Mon) 09:02, David Higgs wrote: On Sat, Dec 6, 2014 at 8:57 AM, Martin Pieuchot mpieuc...@nolizard.org wrote: The ohci(4) diff is almost fine, USBD_SHORT_XFER should only be set in usbd_transfer_complete() so the HCD should only set the status to USBD_NORMAL_COMPLETION, see

Re: upd(4) buggy firmware

2014-12-08 Thread David Higgs
On Mon, Dec 8, 2014 at 9:29 AM, Martin Pieuchot mpieuc...@nolizard.org wrote: On 08/12/14(Mon) 09:02, David Higgs wrote: On Sat, Dec 6, 2014 at 8:57 AM, Martin Pieuchot mpieuc...@nolizard.org wrote: The ohci(4) diff is almost fine, USBD_SHORT_XFER should only be set in

Re: upd(4) buggy firmware

2014-12-08 Thread Martin Pieuchot
On 08/12/14(Mon) 09:35, David Higgs wrote: On Mon, Dec 8, 2014 at 9:29 AM, Martin Pieuchot mpieuc...@nolizard.org wrote: [...] Now I'd like to finish the transition that started with the import of upd(4) and move away from the actual 1 reportID = 1 driver model. Because in the end they

Re: upd(4) buggy firmware

2014-12-08 Thread David Higgs
On Mon, Dec 8, 2014 at 6:07 PM, Martin Pieuchot mpieuc...@nolizard.org wrote: On 08/12/14(Mon) 09:35, David Higgs wrote: On Mon, Dec 8, 2014 at 9:29 AM, Martin Pieuchot mpieuc...@nolizard.org wrote: [...] Now I'd like to finish the transition that started with the import of upd(4) and

Re: upd(4) buggy firmware

2014-12-06 Thread Martin Pieuchot
Hello David, On 05/12/14(Fri) 14:02, David Higgs wrote: On Dec 4, 2014, at 4:30 PM, David Higgs hig...@gmail.com wrote: I am trying to figure out how to handle the buggy USB firmware in my UPS (see misc@ thread from last week). With some kernel debug enabled, I see

Re: upd(4) buggy firmware

2014-12-05 Thread David Higgs
On Dec 4, 2014, at 4:30 PM, David Higgs hig...@gmail.com wrote: I am trying to figure out how to handle the buggy USB firmware in my UPS (see misc@ thread from last week). With some kernel debug enabled, I see usb_transfer_complete: short transfer 35 messages. Since the BatteryPresent

upd(4) buggy firmware

2014-12-04 Thread David Higgs
I am trying to figure out how to handle the buggy USB firmware in my UPS (see misc@ thread from last week). With some kernel debug enabled, I see usb_transfer_complete: short transfer 35 messages. Since the BatteryPresent sensor could not be read, all battery-related sensors were forced into