Re: vmctl(8): uninitialized value

2020-01-02 Thread Pratik Vyas
* Benjamin Baier [2020-01-02 22:01:14 +0100]: On Thu, 2 Jan 2020 18:56:14 +0100 Klemens Nanni wrote: On Thu, Jan 02, 2020 at 04:37:17PM +0100, Benjamin Baier wrote: > "case CMD_SEND:" sets done=1 so ret will never be written to and > the uninitialized value of ret is used to determine the re

Re: vmctl(8): uninitialized value

2020-01-02 Thread Benjamin Baier
On Thu, 2 Jan 2020 18:56:14 +0100 Klemens Nanni wrote: > On Thu, Jan 02, 2020 at 04:37:17PM +0100, Benjamin Baier wrote: > > "case CMD_SEND:" sets done=1 so ret will never be written to and > > the uninitialized value of ret is used to determine the return > > value of the function vmmaction. > G

Re: vmctl(8): uninitialized value

2020-01-02 Thread Klemens Nanni
On Thu, Jan 02, 2020 at 04:37:17PM +0100, Benjamin Baier wrote: > "case CMD_SEND:" sets done=1 so ret will never be written to and > the uninitialized value of ret is used to determine the return > value of the function vmmaction. Good catch: $ doas vmctl start -b ~/vm/bsd.rd -m 128M test

vmctl(8): uninitialized value

2020-01-02 Thread Benjamin Baier
Hi. "case CMD_SEND:" sets done=1 so ret will never be written to and the uninitialized value of ret is used to determine the return value of the function vmmaction. -- Ben Index: main.c === RCS file: /cvs/src/usr.sbin/vmctl/main.c,