Re: vmm(4): swap in log(9) for printf(9) [vmx 3/3]

2021-11-29 Thread Theo de Raadt
Dave Voutila wrote: > Is mispeaking? This is what I experienced: > > panic: acquiring blockable sleep lock with spinlock or critical section > held (kernel_lock) _lock > > Full backtraces of two occurrences: https://imgur.com/a/vKIe3k7 It looks like this began with sys_generic.c 1.130

Re: vmm(4): swap in log(9) for printf(9) [vmx 3/3]

2021-11-29 Thread Dave Voutila
Mark Kettenis writes: >> From: Dave Voutila >> Date: Mon, 29 Nov 2021 07:18:23 -0500 >> >> Mark Kettenis writes: >> >> >> From: Dave Voutila >> >> Date: Sun, 28 Nov 2021 22:51:59 -0500 >> >> >> >> The last vmm diff I'll be sending tonight...promise! This swaps out >> >> usage of printf(9)

Re: vmm(4): swap in log(9) for printf(9) [vmx 3/3]

2021-11-29 Thread Mark Kettenis
> From: Dave Voutila > Date: Mon, 29 Nov 2021 07:18:23 -0500 > > Mark Kettenis writes: > > >> From: Dave Voutila > >> Date: Sun, 28 Nov 2021 22:51:59 -0500 > >> > >> The last vmm diff I'll be sending tonight...promise! This swaps out > >> usage of printf(9) outside the autoconf(4) functions.

Re: vmm(4): swap in log(9) for printf(9) [vmx 3/3]

2021-11-29 Thread Dave Voutila
Mark Kettenis writes: >> From: Dave Voutila >> Date: Sun, 28 Nov 2021 22:51:59 -0500 >> >> The last vmm diff I'll be sending tonight...promise! This swaps out >> usage of printf(9) outside the autoconf(4) functions. >> >> The reason for this change is printf(9) could acquire a sleepable >>

Re: vmm(4): swap in log(9) for printf(9) [vmx 3/3]

2021-11-28 Thread Mark Kettenis
> From: Dave Voutila > Date: Sun, 28 Nov 2021 22:51:59 -0500 > > The last vmm diff I'll be sending tonight...promise! This swaps out > usage of printf(9) outside the autoconf(4) functions. > > The reason for this change is printf(9) could acquire a sleepable > lock. Huh? /* * printf: print a

vmm(4): swap in log(9) for printf(9) [vmx 3/3]

2021-11-28 Thread Dave Voutila
The last vmm diff I'll be sending tonight...promise! This swaps out usage of printf(9) outside the autoconf(4) functions. The reason for this change is printf(9) could acquire a sleepable lock. For VMX-based hosts, this can corrupt the active VMCS as the scheduler may decide to migrate the