Re: xhci(4) isoc: fix bogus handling of chained TRBs

2020-07-28 Thread Marcus Glocker
On Tue, 28 Jul 2020 11:42:43 +0200 Martin Pieuchot wrote: > On 26/07/20(Sun) 16:23, Marcus Glocker wrote: > > On Sun, 26 Jul 2020 13:27:34 + > > sc.dy...@gmail.com wrote: > > > > > On 2020/07/26 10:54, Marcus Glocker wrote: > > > > On Sat, 25 Jul 2020 20:31:44 + > > > > sc.dy...@gmai

Re: xhci(4) isoc: fix bogus handling of chained TRBs

2020-07-28 Thread Martin Pieuchot
On 26/07/20(Sun) 16:23, Marcus Glocker wrote: > On Sun, 26 Jul 2020 13:27:34 + > sc.dy...@gmail.com wrote: > > > On 2020/07/26 10:54, Marcus Glocker wrote: > > > On Sat, 25 Jul 2020 20:31:44 + > > > sc.dy...@gmail.com wrote: > > > > > >> On 2020/07/25 18:10, Marcus Glocker wrote: > >

Re: xhci(4) isoc: fix bogus handling of chained TRBs

2020-07-26 Thread Marcus Glocker
On Sun, 26 Jul 2020 13:27:34 + sc.dy...@gmail.com wrote: > On 2020/07/26 10:54, Marcus Glocker wrote: > > On Sat, 25 Jul 2020 20:31:44 + > > sc.dy...@gmail.com wrote: > > > >> On 2020/07/25 18:10, Marcus Glocker wrote: > >>> On Sun, Jul 19, 2020 at 02:12:21PM +, sc.dy...@gmail.com

Re: xhci(4) isoc: fix bogus handling of chained TRBs

2020-07-26 Thread sc . dying
On 2020/07/26 10:54, Marcus Glocker wrote: > On Sat, 25 Jul 2020 20:31:44 + > sc.dy...@gmail.com wrote: > >> On 2020/07/25 18:10, Marcus Glocker wrote: >>> On Sun, Jul 19, 2020 at 02:12:21PM +, sc.dy...@gmail.com wrote: >>> On 2020/07/19 11:25, Marcus Glocker wrote: > On Sun,

Re: xhci(4) isoc: fix bogus handling of chained TRBs

2020-07-26 Thread Marcus Glocker
On Sat, 25 Jul 2020 20:31:44 + sc.dy...@gmail.com wrote: > On 2020/07/25 18:10, Marcus Glocker wrote: > > On Sun, Jul 19, 2020 at 02:12:21PM +, sc.dy...@gmail.com wrote: > > > >> On 2020/07/19 11:25, Marcus Glocker wrote: > >>> On Sun, 19 Jul 2020 02:25:30 + > >>> sc.dy...@gmail.c

Re: xhci(4) isoc: fix bogus handling of chained TRBs

2020-07-25 Thread sc . dying
On 2020/07/25 18:10, Marcus Glocker wrote: > On Sun, Jul 19, 2020 at 02:12:21PM +, sc.dy...@gmail.com wrote: > >> On 2020/07/19 11:25, Marcus Glocker wrote: >>> On Sun, 19 Jul 2020 02:25:30 + >>> sc.dy...@gmail.com wrote: >>> hi, It works on AMD Bolton xHCI (78141022), Intel

Re: xhci(4) isoc: fix bogus handling of chained TRBs

2020-07-25 Thread Marcus Glocker
On Sun, Jul 19, 2020 at 02:12:21PM +, sc.dy...@gmail.com wrote: > On 2020/07/19 11:25, Marcus Glocker wrote: > > On Sun, 19 Jul 2020 02:25:30 + > > sc.dy...@gmail.com wrote: > > > >> hi, > >> > >> It works on AMD Bolton xHCI (78141022), Intel PCH (1e318086), > >> and ASM1042 (10421b21). >

Re: xhci(4) isoc: fix bogus handling of chained TRBs

2020-07-19 Thread sc . dying
On 2020/07/19 11:25, Marcus Glocker wrote: > On Sun, 19 Jul 2020 02:25:30 + > sc.dy...@gmail.com wrote: > >> hi, >> >> It works on AMD Bolton xHCI (78141022), Intel PCH (1e318086), >> and ASM1042 (10421b21). >> I simply play with ffplay -f v4l2 /dev/video0 to test. > > If your cam supports MJ

Re: xhci(4) isoc: fix bogus handling of chained TRBs

2020-07-19 Thread Marcus Glocker
On Sun, 19 Jul 2020 02:25:30 + sc.dy...@gmail.com wrote: > hi, > > It works on AMD Bolton xHCI (78141022), Intel PCH (1e318086), > and ASM1042 (10421b21). > I simply play with ffplay -f v4l2 /dev/video0 to test. If your cam supports MJPEG it's good to add '-input_format mjpeg' with higher re

Re: xhci(4) isoc: fix bogus handling of chained TRBs

2020-07-18 Thread sc . dying
hi, It works on AMD Bolton xHCI (78141022), Intel PCH (1e318086), and ASM1042 (10421b21). I simply play with ffplay -f v4l2 /dev/video0 to test. At this moment it does not work on VL805, but I have no idea. I'll investigate furthermore... BTW I think xhci_ring_alloc should free ring dma buffer if

Re: xhci(4) isoc: fix bogus handling of chained TRBs

2020-07-18 Thread Marcus Glocker
Hey, On Sat, 18 Jul 2020 00:14:32 + sc.dy...@gmail.com wrote: > hi, > > On 2020/07/15 21:28, sc.dy...@gmail.com wrote: > > hi, > > > > The patch works well on Intel PCH xhci, but not on AMD Bolton xHCI. > > I'll investigate this problem. > > Bolton xHCI sometimes raises following events.

Re: xhci(4) isoc: fix bogus handling of chained TRBs

2020-07-17 Thread sc . dying
hi, On 2020/07/15 21:28, sc.dy...@gmail.com wrote: > hi, > > The patch works well on Intel PCH xhci, but not on AMD Bolton xHCI. > I'll investigate this problem. Bolton xHCI sometimes raises following events. (I added printf Completion Code.) #246 cc 13 remain 0 type 5 origlen 2048 frlengths[6]

Re: xhci(4) isoc: fix bogus handling of chained TRBs

2020-07-15 Thread Marcus Glocker
On Wed, 15 Jul 2020 21:28:29 + sc.dy...@gmail.com wrote: > hi, > > The patch works well on Intel PCH xhci, but not on AMD Bolton xHCI. > I'll investigate this problem. Ok, thanks for checking this - I unfortunately only can test this on a Intel xhci currently. > BTW please check if malloc r

Re: xhci(4) isoc: fix bogus handling of chained TRBs

2020-07-15 Thread sc . dying
hi, The patch works well on Intel PCH xhci, but not on AMD Bolton xHCI. I'll investigate this problem. BTW please check if malloc returns NULL. On 2020/07/13 09:59, Marcus Glocker wrote: > On Sat, 11 Jul 2020 23:43:43 +0200 > Marcus Glocker wrote: > >> On Sat, 11 Jul 2020 20:14:03 +0200 >> Ma

Re: xhci(4) isoc: fix bogus handling of chained TRBs

2020-07-13 Thread Marcus Glocker
On Sat, 11 Jul 2020 23:43:43 +0200 Marcus Glocker wrote: > On Sat, 11 Jul 2020 20:14:03 +0200 > Marcus Glocker wrote: > > > On Sat, 11 Jul 2020 11:56:38 +0200 > > Marcus Glocker wrote: > > > > > On Fri, 10 Jul 2020 14:32:47 +0200 > > > Marcus Glocker wrote: > > > > > > > On Fri, 10 Ju

Re: xhci(4) isoc: fix bogus handling of chained TRBs

2020-07-11 Thread Marcus Glocker
On Sat, 11 Jul 2020 20:14:03 +0200 Marcus Glocker wrote: > On Sat, 11 Jul 2020 11:56:38 +0200 > Marcus Glocker wrote: > > > On Fri, 10 Jul 2020 14:32:47 +0200 > > Marcus Glocker wrote: > > > > > On Fri, 10 Jul 2020 14:19:00 +0200 > > > Patrick Wildt wrote: > > > > > > > On Fri, Jul 10

Re: xhci(4) isoc: fix bogus handling of chained TRBs

2020-07-11 Thread Marcus Glocker
On Sat, 11 Jul 2020 11:56:38 +0200 Marcus Glocker wrote: > On Fri, 10 Jul 2020 14:32:47 +0200 > Marcus Glocker wrote: > > > On Fri, 10 Jul 2020 14:19:00 +0200 > > Patrick Wildt wrote: > > > > > On Fri, Jul 10, 2020 at 01:00:31PM +0200, Marcus Glocker wrote: > > > > > > > Hi All, > > > >

Re: xhci(4) isoc: fix bogus handling of chained TRBs

2020-07-11 Thread Marcus Glocker
On Fri, 10 Jul 2020 14:32:47 +0200 Marcus Glocker wrote: > On Fri, 10 Jul 2020 14:19:00 +0200 > Patrick Wildt wrote: > > > On Fri, Jul 10, 2020 at 01:00:31PM +0200, Marcus Glocker wrote: > > > Hi All, > > > > > > Laurence Tratt was reporting about corrupted video images when > > > using uvid

Re: xhci(4) isoc: fix bogus handling of chained TRBs

2020-07-10 Thread Marcus Glocker
On Fri, 10 Jul 2020 14:19:00 +0200 Patrick Wildt wrote: > On Fri, Jul 10, 2020 at 01:00:31PM +0200, Marcus Glocker wrote: > > Hi All, > > > > Laurence Tratt was reporting about corrupted video images when using > > uvideo(4) on xhci(4) with MJPEG and higher resolutions, e.g. when > > using ffpla

Re: xhci(4) isoc: fix bogus handling of chained TRBs

2020-07-10 Thread Patrick Wildt
On Fri, Jul 10, 2020 at 01:00:31PM +0200, Marcus Glocker wrote: > Hi All, > > Laurence Tratt was reporting about corrupted video images when using > uvideo(4) on xhci(4) with MJPEG and higher resolutions, e.g. when using > ffplay: > > $ ffplay -f v4l2 -input_format mjpeg -video_size 1280x720 -f /

xhci(4) isoc: fix bogus handling of chained TRBs

2020-07-10 Thread Marcus Glocker
Hi All, Laurence Tratt was reporting about corrupted video images when using uvideo(4) on xhci(4) with MJPEG and higher resolutions, e.g. when using ffplay: $ ffplay -f v4l2 -input_format mjpeg -video_size 1280x720 -f /dev/video1 When trying to re-produce the issue on my side, the video images w