Re: yacc: malloc+copy -> strndup()

2017-11-03 Thread Michael W. Bombardieri
On Fri, Nov 03, 2017 at 09:29:16AM +0100, Otto Moerbeek wrote: > On Fri, Nov 03, 2017 at 04:22:43PM +0800, Michael W. Bombardieri wrote: > > > On Fri, Nov 03, 2017 at 04:03:44PM +0800, Michael W. Bombardieri wrote: > > > Hello, > > > > > > In yacc the dup_line() function malloc()'ed a buffer and

Re: yacc: malloc+copy -> strndup()

2017-11-03 Thread Otto Moerbeek
On Fri, Nov 03, 2017 at 04:22:43PM +0800, Michael W. Bombardieri wrote: > On Fri, Nov 03, 2017 at 04:03:44PM +0800, Michael W. Bombardieri wrote: > > Hello, > > > > In yacc the dup_line() function malloc()'ed a buffer and copied > > a line into it. The copied line includes \n. > > Allocate-and-co

Re: yacc: malloc+copy -> strndup()

2017-11-03 Thread Michael W. Bombardieri
On Fri, Nov 03, 2017 at 04:03:44PM +0800, Michael W. Bombardieri wrote: > Hello, > > In yacc the dup_line() function malloc()'ed a buffer and copied > a line into it. The copied line includes \n. > Allocate-and-copy can be done by strndup() in one hit. > I ran this on i386 with awk/awkgram.y and r

yacc: malloc+copy -> strndup()

2017-11-03 Thread Michael W. Bombardieri
Hello, In yacc the dup_line() function malloc()'ed a buffer and copied a line into it. The copied line includes \n. Allocate-and-copy can be done by strndup() in one hit. I ran this on i386 with awk/awkgram.y and rcs/date.y and didn't see any difference in y.tab.c compared to the system's yacc. -