Re: ypldap patch 5: fix aldap_close

2017-12-17 Thread Vadim Zhukov
2017-12-17 6:35 GMT+03:00 Jonathan Matthew : > On Sat, Dec 16, 2017 at 08:38:59PM +0300, Vadim Zhukov wrote: >> 2017-12-06 19:12 GMT+03:00 Vadim Zhukov : >> >> The aldap_close() return value is never checked, and I do not see >> >> any good reason to do that.

Re: ypldap patch 5: fix aldap_close

2017-12-16 Thread Jonathan Matthew
On Sat, Dec 16, 2017 at 08:38:59PM +0300, Vadim Zhukov wrote: > 2017-12-06 19:12 GMT+03:00 Vadim Zhukov : > >> The aldap_close() return value is never checked, and I do not see > >> any good reason to do that. Also, in case close(2) fails, it'll miss > >> freeing other data. >

Re: ypldap patch 5: fix aldap_close

2017-12-16 Thread Vadim Zhukov
2017-12-06 19:12 GMT+03:00 Vadim Zhukov : >> The aldap_close() return value is never checked, and I do not see >> any good reason to do that. Also, in case close(2) fails, it'll miss >> freeing other data. > > I'm blind. :-\ > > The problem I was looking for was right here: the

Re: ypldap patch 5: fix aldap_close

2017-12-06 Thread Vadim Zhukov
> The aldap_close() return value is never checked, and I do not see > any good reason to do that. Also, in case close(2) fails, it'll miss > freeing other data. I'm blind. :-\ The problem I was looking for was right here: the aldap_close() closes the wrong file descriptor. So here is a better

ypldap patch 5: fix aldap_close

2017-12-06 Thread Vadim Zhukov
The aldap_close() return value is never checked, and I do not see any good reason to do that. Also, in case close(2) fails, it'll miss freeing other data. Okay? -- WBR, Vadim Zhukov Index: aldap.c === RCS file: