Re: CVS commit: src/sys/ufs/ufs

2014-05-16 Thread Thomas Schmitt
Hi David Holland: I'm not entirely clear on how this structure is actually used, which is why I hadn't yet made this change myself after the issue came up. :-/ My observation in sys/fs/cd9660 is probably the initial cause for this change. PR kern/48799. I could produce a problem by exporting

Re: CVS commit: src/sys/ufs/ufs

2014-05-16 Thread Martin Husemann
On Fri, May 16, 2014 at 12:12:00AM +0200, Joerg Sonnenberger wrote: I don't think it is a problem by itself as the file handle is opaque, but it is certainly wasteful to not put ufid_ino first. That is not possible, the first few bytes of the structure must match struct fid from fstypes.h. The

The root partition inside a slice.

2014-05-16 Thread Ilia Zykov
Hello. Tell me please. Why now NetBSD can has the root partition only on beginning of a slice? For instance: boot hd0e:netbsd can't find the root if the hd0e is inside a slice and hasn't a dos partition twin. For effectively and flexibility it's not handy. Perfunctory the code inspection has

Re: The root partition inside a slice.

2014-05-16 Thread Martin Husemann
On Fri, May 16, 2014 at 02:21:39PM +0400, Ilia Zykov wrote: Why now NetBSD can has the root partition only on beginning of a slice? For instance: boot hd0e:netbsd can't find the root if the hd0e is inside a slice and hasn't a dos partition twin. I don't quite understand - please give us a

Re: The root partition inside a slice.

2014-05-16 Thread Ilia Zykov
boot hd0e:netbsd can't find the root if the hd0e is inside a slice and hasn't a dos partition twin. I mean the GENERIC kernel. A config's option(config netbsd root on wd0e type ffs) works normal.

Re: The root partition inside a slice.

2014-05-16 Thread Izumi Tsutsui
Why now NetBSD can has the root partition only on beginning of a slice? For instance: boot hd0e:netbsd can't find the root if the hd0e is inside a slice and hasn't a dos partition twin. Which NetBSD version? NetBSD x86 6.1.4 can't handle it and you need the following change (which I'm using

Re: The root partition inside a slice.

2014-05-16 Thread Ilia Zykov
NetBSD x86 6.1.4 can't handle it and you need the following change (which I'm using for my custom 6.1.4 amd64 kernel): http://www.nerv.org/~ryo/netbsd/netbsd/?q=id:20130428T143256Z.b623c8487cf2235d829e0daff70cca59b1b79df8 6.2 will include this fix. --- Izumi Tsutsui I will be

Re: The root partition inside a slice.

2014-05-16 Thread Ilia Zykov
NetBSD x86 6.1.4 can't handle it and you need the following change (which I'm using for my custom 6.1.4 amd64 kernel): http://www.nerv.org/~ryo/netbsd/netbsd/?q=id:20130428T143256Z.b623c8487cf2235d829e0daff70cca59b1b79df8 6.2 will include this fix. I have tried the current(69940) i386

Re: The root partition inside a slice.

2014-05-16 Thread Izumi Tsutsui
I have tried the current(69940) i386 kernel. It's not helped. I have the root partition on ld0e and bootloader on ld0a. Can you also show your boot.cfg? Does it have rndseed /var/db/entropy-file; boot hd0e:netbsd ? If so, probably you have to remove rndseed command from it. IIRC, the current

Re: CVS commit: src/sys/ufs/ufs

2014-05-16 Thread David Laight
On Fri, May 16, 2014 at 03:54:44PM +, David Holland wrote: Indeed rebooting with an updated kernel will give active NFS clients problems, but I am not sure we should realy care nor how we could possibly avoid this one time issue. We have changed encoding of filehandles before (at

Re: CVS commit: src/sys/ufs/ufs

2014-05-16 Thread Martin Husemann
On Fri, May 16, 2014 at 03:54:44PM +, David Holland wrote: The problem is that the tokens are memcmp'd, so if they include struct padding this may not work. All filesystems I've seen init the struct with a full memset to 0, so all padding fields should be initialized as well. However, we

Re: CVS commit: src/sys/ufs/ufs

2014-05-16 Thread David Holland
On Fri, May 16, 2014 at 06:48:06PM +, Martin Husemann wrote: The problem is that the tokens are memcmp'd, so if they include struct padding this may not work. All filesystems I've seen init the struct with a full memset to 0, so all padding fields should be initialized as well.