Re: [PATCH] PUFFS backend allocation (round 3)

2014-10-28 Thread Emmanuel Dreyfus
On Sun, Oct 26, 2014 at 09:21:13AM +0100, J. Hannken-Illjes wrote: - You should recover the error in puffs_vnop_close() too. Should I? puffs_vnop_close() does not cause VOP_STRATEGY to be called, it only send a message to the filesystem: If I recover the VOP_STRATEGy error there I will steall

Re: [PATCH] PUFFS backend allocation (round 3)

2014-10-28 Thread J. Hannken-Illjes
On 28 Oct 2014, at 14:37, Emmanuel Dreyfus m...@netbsd.org wrote: On Sun, Oct 26, 2014 at 09:21:13AM +0100, J. Hannken-Illjes wrote: - You should recover the error in puffs_vnop_close() too. Should I? puffs_vnop_close() does not cause VOP_STRATEGY to be called, it only send a message to the

Re: [PATCH] PUFFS backend allocation (round 3)

2014-10-28 Thread Emmanuel Dreyfus
On Tue, Oct 28, 2014 at 02:52:36PM +0100, J. Hannken-Illjes wrote: NFS allows them and therefore VOP_CLOSE is the last chance to report write errors back to the application. The situation is a bit different: write and fsync call VOP_PUTPAGE which calls VOP_STRATEGY and forgets about the write

Re: [PATCH] PUFFS backend allocation (round 3)

2014-10-28 Thread J. Hannken-Illjes
On 28 Oct 2014, at 15:43, Emmanuel Dreyfus m...@netbsd.org wrote: On Tue, Oct 28, 2014 at 02:52:36PM +0100, J. Hannken-Illjes wrote: NFS allows them and therefore VOP_CLOSE is the last chance to report write errors back to the application. The situation is a bit different: write and fsync

Re: [PATCH] PUFFS backend allocation (round 3)

2014-10-28 Thread Emmanuel Dreyfus
On Tue, Oct 28, 2014 at 06:07:29PM +0100, J. Hannken-Illjes wrote: Confused. If write and/or fsync are synchronous (VOP_PUTPAGES with flag PGO_SYNCIO) no write error will be forgotten. puffs_vnop_stratgy() contains this: /* * : wrong, but kernel can't

Re: [PATCH] PUFFS backend allocation (round 3)

2014-10-28 Thread Thor Lancelot Simon
On Wed, Oct 29, 2014 at 12:11:41AM +, Emmanuel Dreyfus wrote: On Tue, Oct 28, 2014 at 06:07:29PM +0100, J. Hannken-Illjes wrote: Confused. If write and/or fsync are synchronous (VOP_PUTPAGES with flag PGO_SYNCIO) no write error will be forgotten. puffs_vnop_stratgy() contains this:

Re: [PATCH] PUFFS backend allocation (round 3)

2014-10-28 Thread Emmanuel Dreyfus
Thor Lancelot Simon t...@panix.com wrote: Let me rephrase: I call close(), get a error because of a failed asynchronous write. The file is not closed, right? Now if I call Wrong. It's still closed. Thank you for that helpful explanation. Another concern: a file may be open by multiple