Re: KAUTH_SYSTEM_UNENCRYPTED_SWAP

2020-05-18 Thread Michael van Elst
mar...@duskware.de (Martin Husemann) writes: >I agree with both. Leave it an admin decision (and maybe default to >"encrypt"). Also assume that it is possible to complete enough of /etc/rc.d >without any swapping ;-} so a simple setting in /etc/sysctl.conf will do. If you don't allow to disable

Re: KAUTH_SYSTEM_UNENCRYPTED_SWAP

2020-05-18 Thread Martin Husemann
On Mon, May 18, 2020 at 06:21:10PM -0400, Mouse wrote: > >> Always encrypted swap would be even better but ... slow machines. > > Compared to the time required to put the pages out to disk? > > That comparison is relevant only if the system has nothing better to do > than wait for the page

Re: KAUTH_SYSTEM_UNENCRYPTED_SWAP

2020-05-18 Thread Mouse
>> Always encrypted swap would be even better but ... slow machines. > Compared to the time required to put the pages out to disk? That comparison is relevant only if the system has nothing better to do than wait for the page out/in. A few systems probably don't. Most, I suspect, do, and if

Re: KAUTH_SYSTEM_UNENCRYPTED_SWAP

2020-05-18 Thread Taylor R Campbell
> Date: Mon, 18 May 2020 17:51:51 -0400 > From: Thor Lancelot Simon > > On Mon, May 18, 2020 at 09:08:14PM +0100, Alexander Nasonov wrote: > > matthew green wrote: > > > what's the use-case for disabling encrypted swap later? > > > > It might be too slow on some machines. > > > > > i'd argue

Re: KAUTH_SYSTEM_UNENCRYPTED_SWAP

2020-05-18 Thread Thor Lancelot Simon
On Mon, May 18, 2020 at 09:08:14PM +0100, Alexander Nasonov wrote: > matthew green wrote: > > what's the use-case for disabling encrypted swap later? > > It might be too slow on some machines. > > > i'd argue we should avoid kauth for this and simply disable > > it always as i've been unable to

Re: sys/idtype.h unused enumeration values

2020-05-18 Thread Christos Zoulas
The *used* enum values are already burned into existing programs. Reordering/removing from the list breaks ABI. They are best left alone. christos > On May 18, 2020, at 4:55 PM, Kamil Rytarowski wrote: > > Signed PGP part > On 18.05.2020 22:18, Christos Zoulas wrote: >> >> >>> On May 18,

Re: sys/idtype.h unused enumeration values

2020-05-18 Thread Kamil Rytarowski
On 18.05.2020 22:18, Christos Zoulas wrote: > > >> On May 18, 2020, at 3:40 PM, Kamil Rytarowski wrote: >> >> If I delete P_TASKID ... P_P_CPUID ones, P_SETID will be reordered (but >> we can force the number anyway). If I delete P_CID there is an inelegant >> hole. Naturally P_SETID -> P_CID

Re: sys/idtype.h unused enumeration values

2020-05-18 Thread Taylor R Campbell
> Date: Mon, 18 May 2020 21:40:16 +0200 > From: Kamil Rytarowski > > If I delete P_TASKID ... P_P_CPUID ones, P_SETID will be reordered (but > we can force the number anyway). If I delete P_CID there is an inelegant > hole. Naturally P_SETID -> P_CID can fill the gap. > > This is in theory ABI

Re: sys/idtype.h unused enumeration values

2020-05-18 Thread Christos Zoulas
> On May 18, 2020, at 3:40 PM, Kamil Rytarowski wrote: > > If I delete P_TASKID ... P_P_CPUID ones, P_SETID will be reordered (but > we can force the number anyway). If I delete P_CID there is an inelegant > hole. Naturally P_SETID -> P_CID can fill the gap. > > This is in theory ABI change,

Re: KAUTH_SYSTEM_UNENCRYPTED_SWAP

2020-05-18 Thread Alexander Nasonov
matthew green wrote: > what's the use-case for disabling encrypted swap later? It might be too slow on some machines. > i'd argue we should avoid kauth for this and simply disable > it always as i've been unable to think of any use case that > is the only solution. Always encrypted swap would

Re: sys/idtype.h unused enumeration values

2020-05-18 Thread Kamil Rytarowski
On 18.05.2020 21:31, Taylor R Campbell wrote: >> Date: Mon, 18 May 2020 21:11:36 +0200 >> From: Kamil Rytarowski >> >> On 18.05.2020 20:24, Robert Elz wrote: >>> Date:Mon, 18 May 2020 19:45:55 +0200 >>> From:Kamil Rytarowski >>> Message-ID: >>> >>> | I have got a

Re: sys/idtype.h unused enumeration values

2020-05-18 Thread Taylor R Campbell
> Date: Mon, 18 May 2020 21:11:36 +0200 > From: Kamil Rytarowski > > On 18.05.2020 20:24, Robert Elz wrote: > > Date:Mon, 18 May 2020 19:45:55 +0200 > > From:Kamil Rytarowski > > Message-ID: > > > > | I have got a local use-case for another P_type (premature to

Re: sys/idtype.h unused enumeration values

2020-05-18 Thread Kamil Rytarowski
On 18.05.2020 20:24, Robert Elz wrote: > Date:Mon, 18 May 2020 19:45:55 +0200 > From:Kamil Rytarowski > Message-ID: > > | I have got a local use-case for another P_type (premature to discuss it > | in this thread) and I would rather recycle an unused value. > >

Re: sys/idtype.h unused enumeration values

2020-05-18 Thread Robert Elz
Date:Mon, 18 May 2020 19:45:55 +0200 From:Kamil Rytarowski Message-ID: | I have got a local use-case for another P_type (premature to discuss it | in this thread) and I would rather recycle an unused value. Don't do that, it is just a number, use one that

Re: sys/idtype.h unused enumeration values

2020-05-18 Thread Christos Zoulas
I copied these from FreeBSD who in turn copied them from solaris and changed P_ZONEID to P_JAILID. The FreeBSD comment is: http://bxr.su/FreeBSD/sys/sys/wait.h#100 I decided to keep all the names too. christos > On May 18, 2020, at 1:45 PM, Kamil

sys/idtype.h unused enumeration values

2020-05-18 Thread Kamil Rytarowski
POSIX notes: "The type idtype_t shall be defined as an enumeration type whose possible values shall include at least the following: P_ALL P_PGID P_PID" https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_wait.h.html For some reason we copied as-is solaris types into our public headers