Re: General device properties API

2021-08-15 Thread Jason Thorpe
> On Aug 15, 2021, at 6:18 PM, David Holland wrote: >> >> This complaint is at best tangentially related to the topic at >> hand, and can be adjusted separately from this discussion. > > Sure, but let's not forget to, ok? I was also not entirely pleased by > seeing new untyped things going in

Re: General device properties API

2021-08-15 Thread David Holland
On Sun, Aug 15, 2021 at 09:10:48AM -0700, Jason Thorpe wrote: > > Why do we pass untyped strings around with this device_call mechanism? > > Was there any discussion about this beforehand? Had I known it was > > proposed I would have objected to an untyped string method calling > > mechanism

Re: General device properties API

2021-08-15 Thread Jason Thorpe
> On Aug 15, 2021, at 9:56 AM, Taylor R Campbell > wrote: > > Cool, thanks! Can you expand on what it would look like instead with > the new API? Do you have any diffs to particulary compelling messy > drivers or buses to show off how this makes things better? Here’s a pretty solid

Re: General device properties API

2021-08-15 Thread Jason Thorpe
> On Aug 15, 2021, at 9:56 AM, Taylor R Campbell > wrote: > >> Date: Sun, 15 Aug 2021 09:10:48 -0700 >> From: Jason Thorpe >> >>> On Aug 15, 2021, at 2:08 AM, Taylor R Campbell >>> wrote: >>> >>> This is a little abstract to follow just from the types. Can you show >>> examples of: >>>

Re: General device properties API

2021-08-15 Thread Taylor R Campbell
> Date: Sun, 15 Aug 2021 09:10:48 -0700 > From: Jason Thorpe > > > On Aug 15, 2021, at 2:08 AM, Taylor R Campbell > > wrote: > > > > This is a little abstract to follow just from the types. Can you show > > examples of: > > > > - code scattered around to reflect device tree properties? > >

Re: General device properties API

2021-08-15 Thread Jason Thorpe
> On Aug 15, 2021, at 9:30 AM, Michael wrote: > > Does this append a NUL if the property doesn't have one? > IIRC OpenFirmware can be a bit inconsistent with that, I remember doing > things like zeroing the buffer, then requesting buffer_size - 1 from > OF_getprop() to make sure the result is

Re: General device properties API

2021-08-15 Thread Michael
Hello, On Fri, 13 Aug 2021 19:10:20 -0700 Jason Thorpe wrote: > ==> int device_getprop_string(device_t dev, const char *prop, void *buf, int > buflen); > Fetch the specified property as a string info buf, copying at most > buflen bytes, **including the terminating NUL**. If the backing >

Re: General device properties API

2021-08-15 Thread Jason Thorpe
> On Aug 15, 2021, at 2:08 AM, Taylor R Campbell > wrote: > >> Date: Fri, 13 Aug 2021 19:10:20 -0700 >> From: Jason Thorpe >> >> Over the last year or so, I've been playing around with ideas for a >> generic device properties API, and have been slowly adding some >> infrastructure to the

Re: General device properties API

2021-08-15 Thread Taylor R Campbell
> Date: Fri, 13 Aug 2021 19:10:20 -0700 > From: Jason Thorpe > > Over the last year or so, I've been playing around with ideas for a > generic device properties API, and have been slowly adding some > infrastructure to the kernel to enable it. Enough of the > infrastructure is now in place (or