Re: CVS commit: src/bin/cp

2010-10-26 Thread David Holland
On Mon, Oct 25, 2010 at 05:49:11PM +0100, David Laight wrote: > > No, since in general the file is also being extended (certainly in > > this case it is) it also has to lock the file size, and that's going > > to deny stat() until it's done. > > A stat request during a write can safely return

Re: CVS commit: src/bin/cp

2010-10-25 Thread David Laight
On Sun, Oct 24, 2010 at 10:56:40PM +, David Holland wrote: > > > > I think write() only needs to lock the the file enough to ensure that > > the file offset is correct. > > No, since in general the file is also being extended (certainly in > this case it is) it also has to lock the file si

Re: CVS commit: src/bin/cp

2010-10-24 Thread David Holland
(adding tech-kern because this seems likely to become lengthy; if following up please drop source-changes-d) On Sun, Oct 24, 2010 at 11:30:43AM +0100, David Laight wrote: > > > [mmap mode disabled in cp due to long vnode lock waits] > > > > Because individual write() calls are supposed to be at