Dead code: double return

2014-08-18 Thread Maxime Villard
Hi, my code scanner reports in several places lines like these: return ERROR_CODE/func(XXX); return VALUE; Of course the latter is never reached; is there a special syntax meaning behind this? It's ok if I fix them all? I put here [1] those which seem obvious and harmless. Also,

Re: Dead code: double return

2014-08-18 Thread Christos Zoulas
In article 53f1c72d.9070...@m00nbsd.net, Maxime Villard m...@m00nbsd.net wrote: Hi, my code scanner reports in several places lines like these: return ERROR_CODE/func(XXX); return VALUE; Of course the latter is never reached; is there a special syntax meaning behind this? It's ok

Re: Dead code: double return

2014-08-18 Thread Iain Hibbert
On Mon, 18 Aug 2014, Christos Zoulas wrote: In article 53f1c72d.9070...@m00nbsd.net, Maxime Villard m...@m00nbsd.net wrote: Also, I get several panic(XX); return;/break;/continue; in many places; it's ok if I start removing these return;/break;/continue;? I'd fix them. But

Re: Dead code: double return

2014-08-18 Thread Christos Zoulas
On Aug 18, 5:01pm, plu...@ogmig.net (Iain Hibbert) wrote: -- Subject: Re: Dead code: double return | On Mon, 18 Aug 2014, Christos Zoulas wrote: | | In article 53f1c72d.9070...@m00nbsd.net, | Maxime Villard m...@m00nbsd.net wrote: | Also, I get several | | panic(XX); | return

Re: Dead code: double return

2014-08-18 Thread David Young
On Mon, Aug 18, 2014 at 11:28:13AM +0200, Maxime Villard wrote: Hi, my code scanner reports in several places lines like these: return ERROR_CODE/func(XXX); return VALUE; In some of your examples, it looks like code may have been copied and pasted. Is some refactoring of the

re: Dead code: double return

2014-08-18 Thread matthew green
David Young writes: On Mon, Aug 18, 2014 at 11:28:13AM +0200, Maxime Villard wrote: Hi, my code scanner reports in several places lines like these: return ERROR_CODE/func(XXX); return VALUE; In some of your examples, it looks like code may have been copied and pasted. Is