Re: Modularizing net80211 (was: link_set info needed)

2012-04-30 Thread David Laight
On Mon, Apr 30, 2012 at 06:52:52AM -0700, Paul Goyette wrote: > I'd still like to find a way forward with this issue. > > Since we can differentiate (both at compile time and at run-time) > between the two modes (built-in vs loaded), I'd like to propose adding > the data to support both modes in

Re: Modularizing net80211 (was: link_set info needed)

2012-04-30 Thread Paul Goyette
On Sat, 28 Apr 2012, Paul Goyette wrote: For built-in modules, we don't (seem to) have a list of the kernel's program sections, and the module's mod->mod_kobj is NULL. So we can't use the section table to get the start address or size of the section. We do have the start/end symbols that __li

Re: Modularizing net80211 (was: link_set info needed)

2012-04-29 Thread John Nemeth
On Sep 18, 11:45am, David Laight wrote: } Subject: Re: Modularizing net80211 (was: link_set info needed) } > } > This mechanism only works for modules that are "separate" from the } > kernel (loaded via "boot" or from "filesys"). "builtin" modu

Re: Modularizing net80211 (was: link_set info needed)

2012-04-28 Thread Paul Goyette
On Sat, 28 Apr 2012, Paul Goyette wrote: How about another alternative? Rather than using .ctor/dtor for _MODULE mode, and a link-set for the built-in mode, we could extend the modinfo_t structure to include two new members: char *mi_ctor_section, *mi_dtor_section Then the module's

Re: Modularizing net80211 (was: link_set info needed)

2012-04-28 Thread Paul Goyette
How about another alternative? Rather than using .ctor/dtor for _MODULE mode, and a link-set for the built-in mode, we could extend the modinfo_t structure to include two new members: char *mi_ctor_section, *mi_dtor_section Then the module's code can continue to use the link_set para

Re: Modularizing net80211 (was: link_set info needed)

2012-04-28 Thread Joerg Sonnenberger
On Sat, Apr 28, 2012 at 10:13:11AM -0700, Paul Goyette wrote: > But can you provide symbols for the start/end of each module's > portion of the .ctor / .dtor section? I'm not sure you should have to. Otherwise it means that the static state of a module after load is not consistent, which should no

Re: Modularizing net80211 (was: link_set info needed)

2012-04-28 Thread David Laight
On Sat, Apr 28, 2012 at 10:13:11AM -0700, Paul Goyette wrote: > On Sat, 28 Apr 2012, Joerg Sonnenberger wrote: > > >On Sat, Apr 28, 2012 at 05:09:16PM +0100, David Laight wrote: > >>> > >>>This mechanism only works for modules that are "separate" from the > >>>kernel (loaded via "boot" or from "fi

Re: Modularizing net80211 (was: link_set info needed)

2012-04-28 Thread Paul Goyette
On Sat, 28 Apr 2012, Joerg Sonnenberger wrote: On Sat, Apr 28, 2012 at 05:09:16PM +0100, David Laight wrote: This mechanism only works for modules that are "separate" from the kernel (loaded via "boot" or from "filesys"). "builtin" modules still need to use the link_set mechanism. Shouldn't

Re: Modularizing net80211 (was: link_set info needed)

2012-04-28 Thread Joerg Sonnenberger
On Sat, Apr 28, 2012 at 05:09:16PM +0100, David Laight wrote: > > > > This mechanism only works for modules that are "separate" from the > > kernel (loaded via "boot" or from "filesys"). "builtin" modules still > > need to use the link_set mechanism. > > Shouldn't be that hard to put the contr

Re: Modularizing net80211 (was: link_set info needed)

2012-04-28 Thread Paul Goyette
On Sat, 28 Apr 2012, David Laight wrote: This mechanism only works for modules that are "separate" from the kernel (loaded via "boot" or from "filesys"). "builtin" modules still need to use the link_set mechanism. Shouldn't be that hard to put the contructor list address into a link_set - th

Re: Modularizing net80211 (was: link_set info needed)

2012-04-28 Thread David Laight
> > This mechanism only works for modules that are "separate" from the > kernel (loaded via "boot" or from "filesys"). "builtin" modules still > need to use the link_set mechanism. Shouldn't be that hard to put the contructor list address into a link_set - that would make it easy to get them c

Re: Modularizing net80211 (was: link_set info needed)

2012-04-28 Thread Paul Goyette
On Fri, 27 Apr 2012, Joerg Sonnenberger wrote: On Fri, Apr 27, 2012 at 06:34:40AM -0700, Paul Goyette wrote: On Fri, 27 Apr 2012, Joerg Sonnenberger wrote: On Fri, Apr 27, 2012 at 05:51:30AM -0700, Paul Goyette wrote: 3. Replacing the use of link_set with direct calls to all of the crypto/

Re: Modularizing net80211 (was: link_set info needed)

2012-04-27 Thread Joerg Sonnenberger
On Fri, Apr 27, 2012 at 06:34:40AM -0700, Paul Goyette wrote: > On Fri, 27 Apr 2012, Joerg Sonnenberger wrote: > > >On Fri, Apr 27, 2012 at 05:51:30AM -0700, Paul Goyette wrote: > >>3. Replacing the use of link_set with direct calls to all of the > >> crypto/auth initializers. > > > >I believe t

Re: Modularizing net80211 (was: link_set info needed)

2012-04-27 Thread Paul Goyette
On Fri, 27 Apr 2012, Joerg Sonnenberger wrote: On Fri, Apr 27, 2012 at 05:51:30AM -0700, Paul Goyette wrote: 3. Replacing the use of link_set with direct calls to all of the crypto/auth initializers. I believe this to a noticable regression due to bugs in the module framework. It should su

Re: Modularizing net80211 (was: link_set info needed)

2012-04-27 Thread Joerg Sonnenberger
On Fri, Apr 27, 2012 at 05:51:30AM -0700, Paul Goyette wrote: > 3. Replacing the use of link_set with direct calls to all of the >crypto/auth initializers. I believe this to a noticable regression due to bugs in the module framework. It should support either link sets or _init sections. If the

Modularizing net80211 (was: link_set info needed)

2012-04-27 Thread Paul Goyette
Folks, I would like to commit the attached patches to modularize the net80211 code. The changes include: 1. Protecting the inclusion of "opt_inet.h" with #ifdef _KERNEL 2. Removing CTLFLAG_PERMANENT from all of the sysctl(8) variables 3. Replacing the use of link_set with direct calls to all