Re: msdosfs and small sectors

2014-09-10 Thread David Laight
On Wed, Jul 16, 2014 at 06:26:00PM +, David Holland wrote: On Wed, Jul 16, 2014 at 03:10:01PM +0200, Maxime Villard wrote: I thought about that. I haven't found a clear spec on this, but it is implicitly suggested that 512 is the minimal size (from what I've seen here and there). And

Re: msdosfs and small sectors

2014-09-10 Thread Rhialto
On Wed 10 Sep 2014 at 22:53:27 +0100, David Laight wrote: (and ICL system25 whcih wanted 100 byte sectors). Or IBM's CMS which used to have 800 byte sectors. -Olaf. -- ___ Olaf 'Rhialto' Seibert -- The Doctor: No, 'eureka' is Greek for \X/ rhialto/at/xs4all.nl-- 'this bath is too hot.'

Re: msdosfs and small sectors

2014-07-17 Thread Greg Troxel
Maxime Villard m...@m00nbsd.net writes: Le 17/07/2014 06:01, matthew green a écrit : + if (secsize DEV_BSIZE) { +#ifdef DIAGNOSTIC + printf(Invalid block secsize %d\n, secsize); +#endif + error = EINVAL; + goto error_exit; + } if (argp-flags

Re: msdosfs and small sectors

2014-07-16 Thread Maxime Villard
Le 15/07/2014 17:57, Martin Husemann a écrit : On Tue, Jul 15, 2014 at 03:27:08PM +0200, Maxime Villard wrote: 'secsize' is retrieved through getdisksize(), via an ioctl on the device. force it to be 512 bytes minimum? Martin I thought about that. I haven't found a clear spec on this,

Re: msdosfs and small sectors

2014-07-16 Thread Greg Troxel
Maxime Villard m...@m00nbsd.net writes: Le 15/07/2014 17:57, Martin Husemann a écrit : On Tue, Jul 15, 2014 at 03:27:08PM +0200, Maxime Villard wrote: 'secsize' is retrieved through getdisksize(), via an ioctl on the device. force it to be 512 bytes minimum? Martin I thought about

Re: msdosfs and small sectors

2014-07-16 Thread David Holland
On Wed, Jul 16, 2014 at 03:10:01PM +0200, Maxime Villard wrote: I thought about that. I haven't found a clear spec on this, but it is implicitly suggested that 512 is the minimal size (from what I've seen here and there). And the smallest BytesPerSec allowed for fat devices is 512. But

Re: msdosfs and small sectors

2014-07-16 Thread Maxime Villard
I've put 512. It's the least magic limit. - Module Name:src Committed By: maxv Date: Wed Jul 16 20:09:00 UTC 2014 Modified Files: src/sys/fs/msdosfs: msdosfs_vfsops.c Log Message: Limit the

re: msdosfs and small sectors

2014-07-16 Thread matthew green
+ if (secsize DEV_BSIZE) { +#ifdef DIAGNOSTIC + printf(Invalid block secsize %d\n, secsize); +#endif + error = EINVAL; + goto error_exit; + } if (argp-flags MSDOSFSMNT_GEMDOSFS) { if (secsize != GEMDOSFS_BSIZE) { That's an

Re: msdosfs and small sectors

2014-07-15 Thread Martin Husemann
On Tue, Jul 15, 2014 at 03:27:08PM +0200, Maxime Villard wrote: 'secsize' is retrieved through getdisksize(), via an ioctl on the device. force it to be 512 bytes minimum? Martin