Re: Vnode API change: VOP_LOOKUP

2014-02-26 Thread David Holland
On Thu, Feb 06, 2014 at 04:42:07PM +, Taylor R Campbell wrote: >> One more question: Are you planning to change relookup to return the >> result unlocked, too? That will enable us to get rid of some ick in >> genfs_rename users. > >I have no plans to do it -- I'm not eve

Re: Vnode API change: VOP_LOOKUP

2014-02-06 Thread J. Hannken-Illjes
On Feb 6, 2014, at 4:23 PM, Taylor R Campbell wrote: > Date: Mon, 3 Feb 2014 12:04:27 +0100 > From: J. Hannken-Illjes > > As announced some weeks ago here comes the API change to VOP_LOOKUP: > > Change vnode operation lookup to return the resulting vnode *vpp locked. > Change ca

Re: Vnode API change: VOP_LOOKUP

2014-02-06 Thread Taylor R Campbell
Date: Thu, 6 Feb 2014 17:16:18 +0100 From: "J. Hannken-Illjes" On Feb 6, 2014, at 4:52 PM, Taylor R Campbell wrote: > One more question: Are you planning to change relookup to return the > result unlocked, too? That will enable us to get rid of some ick in > genfs_rename us

Re: Vnode API change: VOP_LOOKUP

2014-02-06 Thread J. Hannken-Illjes
On Feb 6, 2014, at 4:52 PM, Taylor R Campbell wrote: > Date: Mon, 3 Feb 2014 12:04:27 +0100 > From: J. Hannken-Illjes > > As announced some weeks ago here comes the API change to VOP_LOOKUP: > > Change vnode operation lookup to return the resulting vnode *vpp locked. > Change ca

Re: Vnode API change: VOP_LOOKUP

2014-02-06 Thread Taylor R Campbell
Date: Mon, 3 Feb 2014 12:04:27 +0100 From: J. Hannken-Illjes As announced some weeks ago here comes the API change to VOP_LOOKUP: Change vnode operation lookup to return the resulting vnode *vpp locked. Change cache_lookup() to return an unlocked vnode. One more question: Ar

Re: Vnode API change: VOP_LOOKUP

2014-02-06 Thread Taylor R Campbell
Date: Mon, 3 Feb 2014 12:04:27 +0100 From: J. Hannken-Illjes As announced some weeks ago here comes the API change to VOP_LOOKUP: Change vnode operation lookup to return the resulting vnode *vpp locked. Change cache_lookup() to return an unlocked vnode. Sounds like the right

Vnode API change: VOP_LOOKUP

2014-02-03 Thread J . Hannken-Illjes
As announced some weeks ago here comes the API change to VOP_LOOKUP: Change vnode operation lookup to return the resulting vnode *vpp locked. Change cache_lookup() to return an unlocked vnode. The fast path through the name cache doesn't add unlock/locks. Most file systems now do this on cac