Re: fcntl(F_GETPATH) support

2019-09-17 Thread Jason Thorpe
> On Sep 17, 2019, at 9:08 PM, Takashi YAMAMOTO wrote: > > but it would be a super expensive operation for the majority of filesystems, > right? But it will most likely be extremely rare, so *shrug*? -- thorpej

Re: fcntl(F_GETPATH) support

2019-09-17 Thread Takashi YAMAMOTO
2019年9月16日(月) 3:43 Jason Thorpe : > > > > On Sep 15, 2019, at 11:03 AM, Christos Zoulas > wrote: > > > > I think it is quite reliable because all the file descriptors would be > recently > > opened and therefore be in the cache. One would need to DoS the cache > > cause eviction. If that turns

Re: fcntl(F_GETPATH) support

2019-09-17 Thread Takashi YAMAMOTO
2019年9月15日(日) 9:06 Christos Zoulas : > In article <2f29ca9a-0ae1-48d3-b3f4-1556912d4...@me.com>, > Jason Thorpe wrote: > > > > > >> On Sep 14, 2019, at 2:52 PM, Kamil Rytarowski wrote: > >> > >> On 14.09.2019 23:34, Christos Zoulas wrote: > >>> Comments? > >>> > >> > >> Question. How does it

Re: fcntl(F_GETPATH) support

2019-09-17 Thread Christos Zoulas
In article , Jason Thorpe wrote: > > >> On Sep 17, 2019, at 1:39 PM, Christos Zoulas wrote: >> >> I am not sure though if we should change the current behavior just to make >> F_GETPATH better? Opinions? > >It seems completely logical that we SHOULD fix this. I concur. Specially because some

Re: fcntl(F_GETPATH) support

2019-09-17 Thread Jason Thorpe
> On Sep 17, 2019, at 1:39 PM, Christos Zoulas wrote: > > I am not sure though if we should change the current behavior just to make > F_GETPATH better? Opinions? It seems completely logical that we SHOULD fix this. -- thorpej

Re: fcntl(F_GETPATH) support

2019-09-17 Thread Christos Zoulas
In article <4e7e49e0-9c71-1f21-22fc-8ed54590a...@gmx.com>, Kamil Rytarowski wrote: >-=-=-=-=-=- >-=-=-=-=-=- > >On 15.09.2019 20:03, Christos Zoulas wrote: >> I think it is quite reliable because all the file descriptors would be >recently >> opened and therefore be in the cache. One would need

Re: fcntl(F_GETPATH) support

2019-09-16 Thread Mateusz Guzik
On 9/15/19, Jason Thorpe wrote: > > >> On Sep 15, 2019, at 11:03 AM, Christos Zoulas >> wrote: >> >> I think it is quite reliable because all the file descriptors would be >> recently >> opened and therefore be in the cache. One would need to DoS the cache >> cause eviction. If that turns out

Re: fcntl(F_GETPATH) support

2019-09-15 Thread Kamil Rytarowski
On 15.09.2019 20:03, Christos Zoulas wrote: > I think it is quite reliable because all the file descriptors would be > recently > opened and therefore be in the cache. One would need to DoS the cache > cause eviction. If that turns out to be false, we can make the namecache > reliable, or

Re: fcntl(F_GETPATH) support

2019-09-15 Thread Jason Thorpe
> On Sep 15, 2019, at 1:17 PM, Mouse wrote: > > [top-posting damage repaired manually] >>> If you can get a file desriptor to a symlink, it will work; I don't >>> think that we have a way to do this now. >> FYI - XNU has O_SYMLINK for this. > > What operations does it support on fds open

Re: fcntl(F_GETPATH) support

2019-09-15 Thread Mouse
>>> If you can get a file desriptor to a symlink, [...] > There should be no way to get a fd for a symlink; if you can, > something bad has happened. At present, perhaps. > Because of the way short symlinks are handled in ffs, I wouldn't be > surprised if managing to get one let you corrupt the

Re: fcntl(F_GETPATH) support

2019-09-15 Thread Mouse
[top-posting damage repaired manually] >> If you can get a file desriptor to a symlink, it will work; I don't >> think that we have a way to do this now. > FYI - XNU has O_SYMLINK for this. What operations does it support on fds open onto symlinks? /~\ The ASCII Mouse

Re: fcntl(F_GETPATH) support

2019-09-15 Thread David Holland
On Sun, Sep 15, 2019 at 09:53:41AM -0700, Jason Thorpe wrote: > FYI - XNU has O_SYMLINK for this. Not saying we should necessarily add it > to NetBSD, just noting the precedent. > > -- thorpej > Sent from my iPhone. > > > On Sep 14, 2019, at 5:06 PM, Christos Zoulas wrote: > > > >

Re: fcntl(F_GETPATH) support

2019-09-15 Thread Jason Thorpe
> On Sep 15, 2019, at 11:03 AM, Christos Zoulas wrote: > > I think it is quite reliable because all the file descriptors would be > recently > opened and therefore be in the cache. One would need to DoS the cache > cause eviction. If that turns out to be false, we can make the namecache >

Re: fcntl(F_GETPATH) support

2019-09-15 Thread Mateusz Guzik
On 9/15/19, Mateusz Guzik wrote: > On 9/14/19, Christos Zoulas wrote: >> >> Comments? >> >> +error = vnode_to_path(kpath, MAXPATHLEN, fp->f_vnode, l, l->l_proc); > > What motivates this change? > > I think it is a little problematic in that namecache resolution is not > guaranteed to work.

Re: fcntl(F_GETPATH) support

2019-09-15 Thread Mateusz Guzik
On 9/14/19, Christos Zoulas wrote: > > Comments? > > + error = vnode_to_path(kpath, MAXPATHLEN, fp->f_vnode, l, l->l_proc); What motivates this change? I think it is a little problematic in that namecache resolution is not guaranteed to work. If the consumer does not check for failure or

Re: fcntl(F_GETPATH) support

2019-09-15 Thread Christos Zoulas
> On Sep 15, 2019, at 12:43 PM, Mateusz Guzik wrote: > > On 9/14/19, Christos Zoulas wrote: >> >> Comments? >> >> +error = vnode_to_path(kpath, MAXPATHLEN, fp->f_vnode, l, l->l_proc); > > What motivates this change? > > I think it is a little problematic in that namecache resolution

Re: fcntl(F_GETPATH) support

2019-09-15 Thread Jason Thorpe
FYI - XNU has O_SYMLINK for this. Not saying we should necessarily add it to NetBSD, just noting the precedent. -- thorpej Sent from my iPhone. > On Sep 14, 2019, at 5:06 PM, Christos Zoulas wrote: > > If you can get a file desriptor to a symlink, it will work; I don't think > that we have a

Re: fcntl(F_GETPATH) support

2019-09-14 Thread Christos Zoulas
In article <2f29ca9a-0ae1-48d3-b3f4-1556912d4...@me.com>, Jason Thorpe wrote: > > >> On Sep 14, 2019, at 2:52 PM, Kamil Rytarowski wrote: >> >> On 14.09.2019 23:34, Christos Zoulas wrote: >>> Comments? >>> >> >> Question. How does it handle symbolic/hardlinks? > >Symbolic links, of course,

Re: fcntl(F_GETPATH) support

2019-09-14 Thread Jason Thorpe
> On Sep 14, 2019, at 2:52 PM, Kamil Rytarowski wrote: > > On 14.09.2019 23:34, Christos Zoulas wrote: >> Comments? >> > > Question. How does it handle symbolic/hardlinks? Symbolic links, of course, are simply continuations of the lookup, so there's "nothing to see here" with a symbolic

Re: fcntl(F_GETPATH) support

2019-09-14 Thread Kamil Rytarowski
On 14.09.2019 23:34, Christos Zoulas wrote: > Comments? > Question. How does it handle symbolic/hardlinks? > christos > > > Index: kern/sys_descrip.c > === > RCS file: /cvsroot/src/sys/kern/sys_descrip.c,v > retrieving revision

fcntl(F_GETPATH) support

2019-09-14 Thread Christos Zoulas
Comments? christos Index: kern/sys_descrip.c === RCS file: /cvsroot/src/sys/kern/sys_descrip.c,v retrieving revision 1.34 diff -u -p -u -r1.34 sys_descrip.c --- kern/sys_descrip.c 26 Aug 2019 10:19:08 - 1.34 +++