On Mon, Jun 21, 2010 at 06:23:02PM -0400, Christos Zoulas wrote:
Well, I find the different indentation styles typically use for the braces
clumsy and not following the standard. Or even when they do, they cause the
code to move too much to the right:
1. don't like the two }} at the same
In article 20100622182446.ga3...@nimenees.com,
Eric Haszlakiewicz e...@nimenees.com wrote:
btw, there's a 5th option that is a bit in between:
switch (c) {
int myvar;
case 'a':
myvar = somevalue;
stmt;
}
but I wouldn't recommend it b/c variable initialization on the
On Mon, Jun 21, 2010 at 05:11:26PM -0500, Eric Haszlakiewicz wrote:
- declare the variables on top to avoid braces in case statements.
Is this really a bad thing? I find it makes things more readable.
(although I tend to line things up a bit differently in my code, keeping the
code in
On Mon, Jun 21, 2010 at 06:23:02PM -0400, Christos Zoulas wrote:
Well, I find the different indentation styles typically use for the braces
clumsy and not following the standard. Or even when they do, they cause the
code to move too much to the right:
FWIW, I prefer this:
switch (c) {
In article 20100621053340.ga1...@boogers.sf.ca.us,
Jeff Rizzo r...@netbsd.org wrote:
I had occasion to use wedges on a vnd(4), only to be reminded that they're
not currently supported. Anyone see a problem with this patch? I've
given it light testing, and haven't come across any issues yet...
-
On Mon, Jun 21, 2010 at 02:45:42PM +, Christos Zoulas wrote:
- declare the variables on top to avoid braces in case statements.
- KNF continuation lines (indent-by-four) and lose the ()'s around return
Updated patch below. As an aside, this ss clearly more KNF, but I have to
say it's
On Jun 21, 5:11pm, e...@nimenees.com (Eric Haszlakiewicz) wrote:
-- Subject: Re: wedges on vnd(4) patch
| On Mon, Jun 21, 2010 at 02:45:42PM +, Christos Zoulas wrote:
| In article 20100621053340.ga1...@boogers.sf.ca.us,
| Jeff Rizzo r...@netbsd.org wrote:
| I had occasion to use wedges
On Jun 21, 11:52am, r...@netbsd.org (Jeff Rizzo) wrote:
-- Subject: Re: wedges on vnd(4) patch
| On Mon, Jun 21, 2010 at 02:45:42PM +, Christos Zoulas wrote:
|
| - declare the variables on top to avoid braces in case statements.
| - KNF continuation lines (indent-by-four) and lose
I had occasion to use wedges on a vnd(4), only to be reminded that they're
not currently supported. Anyone see a problem with this patch? I've
given it light testing, and haven't come across any issues yet...
+j
Index: sys/dev/vnd.c
